From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbcA0F6F (ORCPT ); Wed, 27 Jan 2016 00:58:05 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:35335 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcA0F6A (ORCPT ); Wed, 27 Jan 2016 00:58:00 -0500 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: ego@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-pm@vger.kernel.org Date: Wed, 27 Jan 2016 11:27:51 +0530 From: Gautham R Shenoy To: Viresh Kumar Cc: Juri Lelli , "Gautham R. Shenoy" , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shilpasri G Bhat Subject: Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list Message-ID: <20160127055751.GA28238@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com> <20160125095029.GE3183@vireshk> <20160125111824.GH10898@e106622-lin> <20160125112215.GB9155@vireshk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160125112215.GB9155@vireshk> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012705-0025-0000-0000-000020C88B59 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 04:52:15PM +0530, Viresh Kumar wrote: > On 25-01-16, 11:18, Juri Lelli wrote: > > Hi, > > > > On 25/01/16 15:20, Viresh Kumar wrote: > > > On 25-01-16, 15:16, Gautham R. Shenoy wrote: > > > > Currently next_policy() explicitly checks if a policy is the last > > > > policy in the cpufreq_policy_list. Use the standard list_is_last > > > > primitive instead. > > > > > > > > Cc: Viresh Kumar > > > > Signed-off-by: Gautham R. Shenoy > > > > --- > > > > drivers/cpufreq/cpufreq.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > > > index 78b1e2f..b3059a3 100644 > > > > --- a/drivers/cpufreq/cpufreq.c > > > > +++ b/drivers/cpufreq/cpufreq.c > > > > @@ -67,11 +67,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy, > > > > { > > > > lockdep_assert_held(&cpufreq_driver_lock); > > > > Which branch is this patch based on? > > Dude, what's going on here? How come you rebased on Juri's patches ? > :) Ah right! I found this issue while reviewing Juri's patches from the cpufreq-cleanups branch and didn't switch back to pm-next before making this change. Shall resend the patch. > > -- > viresh > -- Thanks and Regards gautham.