From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037AbcA0Jz4 (ORCPT ); Wed, 27 Jan 2016 04:55:56 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:49218 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbcA0Jzu (ORCPT ); Wed, 27 Jan 2016 04:55:50 -0500 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-arch@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Wed, 27 Jan 2016 10:55:43 +0100 From: Heiko Carstens To: Christian Borntraeger Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, Joonsoo Kim , davej@codemonkey.org.uk Subject: Re: [PATCH v2 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Message-ID: <20160127095543.GB4439@osiris> References: <1453884618-33852-1-git-send-email-borntraeger@de.ibm.com> <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012709-0041-0000-0000-000007113E74 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2016 at 09:50:18AM +0100, Christian Borntraeger wrote: > We can use debug_pagealloc_enabled() to check if we can map > the identity mapping with 1MB/2GB pages as well as to print > the current setting in dump_stack. > > Signed-off-by: Christian Borntraeger > --- > arch/s390/kernel/dumpstack.c | 8 ++++---- > arch/s390/mm/vmem.c | 10 ++++------ > 2 files changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c > index dc8e204..3f352e9 100644 > --- a/arch/s390/kernel/dumpstack.c > +++ b/arch/s390/kernel/dumpstack.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -184,10 +185,9 @@ void die(struct pt_regs *regs, const char *str) > #endif > #ifdef CONFIG_SMP > printk("SMP "); > -#endif > -#ifdef CONFIG_DEBUG_PAGEALLOC > - printk("DEBUG_PAGEALLOC"); > -#endif > +#endif > +if (debug_pagealloc_enabled()) > + printk("DEBUG_PAGEALLOC"); > printk("\n"); Indentation is broken ("if"). Besides that Reviewed-by: Heiko Carstens From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: [PATCH v2 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Date: Wed, 27 Jan 2016 10:55:43 +0100 Message-ID: <20160127095543.GB4439@osiris> References: <1453884618-33852-1-git-send-email-borntraeger@de.ibm.com> <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com> Sender: owner-linux-mm@kvack.org List-Archive: List-Post: To: Christian Borntraeger Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, Joonsoo Kim , davej@codemonkey.org.uk List-ID: On Wed, Jan 27, 2016 at 09:50:18AM +0100, Christian Borntraeger wrote: > We can use debug_pagealloc_enabled() to check if we can map > the identity mapping with 1MB/2GB pages as well as to print > the current setting in dump_stack. > > Signed-off-by: Christian Borntraeger > --- > arch/s390/kernel/dumpstack.c | 8 ++++---- > arch/s390/mm/vmem.c | 10 ++++------ > 2 files changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c > index dc8e204..3f352e9 100644 > --- a/arch/s390/kernel/dumpstack.c > +++ b/arch/s390/kernel/dumpstack.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -184,10 +185,9 @@ void die(struct pt_regs *regs, const char *str) > #endif > #ifdef CONFIG_SMP > printk("SMP "); > -#endif > -#ifdef CONFIG_DEBUG_PAGEALLOC > - printk("DEBUG_PAGEALLOC"); > -#endif > +#endif > +if (debug_pagealloc_enabled()) > + printk("DEBUG_PAGEALLOC"); > printk("\n"); Indentation is broken ("if"). Besides that Reviewed-by: Heiko Carstens -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org