From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbcA0Kv2 (ORCPT ); Wed, 27 Jan 2016 05:51:28 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34264 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbcA0KvW (ORCPT ); Wed, 27 Jan 2016 05:51:22 -0500 Date: Wed, 27 Jan 2016 21:51:12 +1100 From: Balbir Singh To: Torsten Duwe Cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v6 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Message-ID: <20160127215112.080eec56@cotter.ozlabs.ibm.com> In-Reply-To: <20160125170459.14DB7692CE@newverein.lst.de> References: <20160125170459.14DB7692CE@newverein.lst.de> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2016 16:38:48 +0100 Torsten Duwe wrote: > Changes since v5: > * extra "std r0,LRSAVE(r1)" for gcc-6 > This makes the code compiler-agnostic. > * Follow Petr Mladek's suggestion to avoid > redefinition of HAVE_LIVEPATCH I looked at the patches - well mostly patches 1 and 2, some quick questions 1. I know -mprofile-kernel is a big optimization win, do we need it or can we incrementally add it? 2. Some of the hardcoded checks for opcode are hard to review, I know they've been there in similar forms for a while. May be as an iterative step we should give the numbers some meaning and use proper helpers for it. I am going to give the patches a spin Balbir Singh.