From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOnD6-0004Nt-TL for qemu-devel@nongnu.org; Thu, 28 Jan 2016 09:06:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOnD0-0003Zl-WA for qemu-devel@nongnu.org; Thu, 28 Jan 2016 09:06:08 -0500 Received: from indium.canonical.com ([91.189.90.7]:51476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOnD0-0003ZR-Qe for qemu-devel@nongnu.org; Thu, 28 Jan 2016 09:06:02 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1aOnCz-00037c-FZ for ; Thu, 28 Jan 2016 14:06:01 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 7292E2E80C4 for ; Thu, 28 Jan 2016 14:06:01 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 28 Jan 2016 13:57:54 -0000 From: Kevin Wolf <1538541@bugs.launchpad.net> Sender: bounces@canonical.com References: <20160127125558.31349.12989.malonedeb@gac.canonical.com> Message-Id: <20160128135754.31072.33238.malone@gac.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1538541] Re: qcow2 rejects request to use preallocation with backing file Reply-To: Bug 1538541 <1538541@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The idea that qcow2 could just reserve enough space that it will never need any additional clusters stands on somewhat shaky ground anyway. You can count in metadata such as refcount tables/blocks and the L1/L2 table for an image with the full virtual disk size used. This doesn't cover things like snapshots or in the future bitmaps; I'm not completely sure, but it might also fail to cover some scenarios that involve discard and where some space isn't immediately reused due to image fragmentation. Whether or not a given static size is sufficient for an image depends primarily on how the image is going to be used. What you seem to want isn't really qcow2 preallocation (which would involve, as Max said, preallocating all clusters on the qcow2 level), but preallocation of the image file in the file system layer to a size that matches your use of qcow2. I'm afraid that doing this in the management layer, which actually knows best how it's going to use the image, makes more sense than letting qemu guess and implement a hack that preallocates only on the file system, but not the image format level. -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1538541 Title: qcow2 rejects request to use preallocation with backing file Status in QEMU: New Bug description: The 'preallocation=3Dfull' option to qemu-img / qcow2 block driver instructs QEMU to fully allocate the host file to the maximum size needed by the logical disk size. $ qemu-img create -f qcow2 -o preallocation=3Dfull base.qcow2 200M Formatting 'base.qcow2', fmt=3Dqcow2 size=3D209715200 encryption=3Doff cl= uster_size=3D65536 preallocation=3D'full' lazy_refcounts=3Doff refcount_bit= s=3D16 $ ls -alhs base.qcow2 = 201M -rw-r--r--. 1 berrange berrange 201M Jan 27 12:49 base.qcow2 = When specifying a backing file for the qcow2 file, however, it rejects th= e preallocation request $ qemu-img create -f qcow2 -o preallocation=3Dfull,backing_file=3Dbase.qc= ow2 front.qcow2 200M Formatting 'front.qcow2', fmt=3Dqcow2 size=3D209715200 backing_file=3D'ba= se.qcow2' encryption=3Doff cluster_size=3D65536 preallocation=3D'full' lazy= _refcounts=3Doff refcount_bits=3D16 qemu-img: front.qcow2: Backing file and preallocation cannot be used at t= he same time = It might seem like requesting full preallocation is redundant because mos= t data associated with the image will be present in the backing file, as so= the top layer is unlikely to ever need the full preallocation. Rejecting = this, however, means it is not (officially) possible to reserve disk space = for the top layer to guarantee that future copy-on-writes will never get EN= OSPC. OpenStack in particular uses backing files with all images, in order to avoid the I/O overhead of copying the backing file contents into the per-VM disk image. It, however, still wants to have a guarantee that the per-VM image will never hit an ENOSPC scenario. Currently it has to hack around QEMU's refusal to allow backing_file + preallocation, by calling 'fallocate' on the qcow2 file after it has been created. This is an inexact fix though, because it doesn't take account of fact that qcow2 metadata can takes some MBs of space. Thus, it would like to see preallocation=3Dfull supported in combination with backing files. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1538541/+subscriptions