From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOr8h-0002Tb-A1 for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:17:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOr8e-00049U-4T for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:17:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOr8d-00049B-VH for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:17:48 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 77B6EC0B66FE for ; Thu, 28 Jan 2016 18:17:47 +0000 (UTC) Date: Thu, 28 Jan 2016 18:17:43 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160128181743.GF2911@work-vm> References: <1452599056-27357-1-git-send-email-berrange@redhat.com> <1452599056-27357-7-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452599056-27357-7-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 06/22] migration: force QEMUFile to blocking mode for outgoing migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Amit Shah , qemu-devel@nongnu.org, Juan Quintela * Daniel P. Berrange (berrange@redhat.com) wrote: > Instead of relying on the default QEMUFile I/O blocking flag > state, explicitly turn on blocking I/O for outgoing migration > since it takes place in a background thread. > > Signed-off-by: Daniel P. Berrange > --- > migration/migration.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/migration/migration.c b/migration/migration.c > index c964a8d..715f069 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -1732,6 +1732,7 @@ void migrate_fd_connect(MigrationState *s) > s->expected_downtime = max_downtime/1000000; > s->cleanup_bh = qemu_bh_new(migrate_fd_cleanup, s); > > + qemu_file_set_blocking(s->file, true); Yes OK; fd_connect is the outgoing side and qemu_fopen_socket already sets blocking on "w". Reviewed-by: Dr. David Alan Gilbert > qemu_file_set_rate_limit(s->file, > s->bandwidth_limit / XFER_LIMIT_RATIO); > > -- > 2.5.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK