From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967775AbcA1Vv2 (ORCPT ); Thu, 28 Jan 2016 16:51:28 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36530 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933201AbcA1VvY (ORCPT ); Thu, 28 Jan 2016 16:51:24 -0500 Date: Thu, 28 Jan 2016 22:51:22 +0100 From: Michal Hocko To: Tetsuo Handa Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de, rientjes@google.com, torvalds@linux-foundation.org, oleg@redhat.com, hughd@google.com, andrea@kernel.org, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/2] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space Message-ID: <20160128215121.GE621@dhcp22.suse.cz> References: <1452094975-551-1-git-send-email-mhocko@kernel.org> <1452516120-5535-1-git-send-email-mhocko@kernel.org> <201601181335.JJD69226.JHVQSMFOFOFtOL@I-love.SAKURA.ne.jp> <20160126163823.GG27563@dhcp22.suse.cz> <201601282024.JBG90615.JLFQOSFFVOMHtO@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201601282024.JBG90615.JLFQOSFFVOMHtO@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 28-01-16 20:24:36, Tetsuo Handa wrote: [...] > I like the OOM reaper approach but I can't agree on merging the OOM reaper > without providing a guaranteed last resort at the same time. If you do want > to start the OOM reaper as simple as possible (without being bothered by > a lot of possible corner cases), please pursue a guaranteed last resort > at the same time. I am getting tired of this level of argumentation. oom_reaper in its current form is a step forward. I have acknowledged there are possible improvements doable on top but I do not see them necessary for the core part being merged. I am not trying to rush this in because I am very well aware of how subtle and complex all the interactions might be. So please stop your "we must have it all at once" attitude. This is nothing we have to rush in. We are not talking about a regression which has to be absolutely fixed in few days. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by kanga.kvack.org (Postfix) with ESMTP id A08066B0254 for ; Thu, 28 Jan 2016 16:51:24 -0500 (EST) Received: by mail-wm0-f41.google.com with SMTP id p63so44010271wmp.1 for ; Thu, 28 Jan 2016 13:51:24 -0800 (PST) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com. [74.125.82.67]) by mx.google.com with ESMTPS id 2si17858703wjr.171.2016.01.28.13.51.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jan 2016 13:51:23 -0800 (PST) Received: by mail-wm0-f67.google.com with SMTP id r129so6341740wmr.0 for ; Thu, 28 Jan 2016 13:51:23 -0800 (PST) Date: Thu, 28 Jan 2016 22:51:22 +0100 From: Michal Hocko Subject: Re: [PATCH 3/2] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space Message-ID: <20160128215121.GE621@dhcp22.suse.cz> References: <1452094975-551-1-git-send-email-mhocko@kernel.org> <1452516120-5535-1-git-send-email-mhocko@kernel.org> <201601181335.JJD69226.JHVQSMFOFOFtOL@I-love.SAKURA.ne.jp> <20160126163823.GG27563@dhcp22.suse.cz> <201601282024.JBG90615.JLFQOSFFVOMHtO@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201601282024.JBG90615.JLFQOSFFVOMHtO@I-love.SAKURA.ne.jp> Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de, rientjes@google.com, torvalds@linux-foundation.org, oleg@redhat.com, hughd@google.com, andrea@kernel.org, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu 28-01-16 20:24:36, Tetsuo Handa wrote: [...] > I like the OOM reaper approach but I can't agree on merging the OOM reaper > without providing a guaranteed last resort at the same time. If you do want > to start the OOM reaper as simple as possible (without being bothered by > a lot of possible corner cases), please pursue a guaranteed last resort > at the same time. I am getting tired of this level of argumentation. oom_reaper in its current form is a step forward. I have acknowledged there are possible improvements doable on top but I do not see them necessary for the core part being merged. I am not trying to rush this in because I am very well aware of how subtle and complex all the interactions might be. So please stop your "we must have it all at once" attitude. This is nothing we have to rush in. We are not talking about a regression which has to be absolutely fixed in few days. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org