From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP0Kd-0000d0-MN for qemu-devel@nongnu.org; Thu, 28 Jan 2016 23:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP0KZ-0002jH-KP for qemu-devel@nongnu.org; Thu, 28 Jan 2016 23:06:47 -0500 Date: Fri, 29 Jan 2016 13:36:21 +1100 From: David Gibson Message-ID: <20160129023620.GF23043@voom.redhat.com> References: <1453889591-30968-1-git-send-email-david@gibson.dropbear.id.au> <56AA7DC5.8050802@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vKFfOv5t3oGVpiF+" Content-Disposition: inline In-Reply-To: <56AA7DC5.8050802@suse.de> Subject: Re: [Qemu-devel] [PATCHv2 00/10] Clean up page size handling for ppc 64-bit hash MMUs with TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, qemu-ppc@nongnu.org --vKFfOv5t3oGVpiF+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 28, 2016 at 09:44:53PM +0100, Alexander Graf wrote: >=20 >=20 > On 01/27/2016 11:13 AM, David Gibson wrote: > >Encoding of page sizes on 64-bit hash MMUs for Power is rather arcane, > >involving control bits in both the SLB and HPTE. At present we > >support a few of the options, but far fewer than real hardware. > > > >We're able to get away with that in practice, because guests use a > >device tree property to determine which page sizes are available and > >we are setting that to match. However, the fact that the actual code > >doesn't necessarily what we put into the table of available page sizes > >is another ugliness. > > > >This series makes a number of cleanups to the page size handling. The > >upshot is that afterwards the softmmu code operates off the same page > >size encoding table that is advertised to the guests, ensuring that > >they will be in sync. > > > >Finally, we extend the table of allowed sizes for POWER7 and POWER8 to > >include the options allowed in hardware (including MPSS). We can fix > >other hash MMU based CPUs in future if anyone cares enough. > > > >For a simple benchmark I timed fully booting then cleanly shutting > >down a TCG guest (RHEL7.2 userspace with a recent upstream kernel). > >Repeated 5 times on the current master branch, my current ppc-for-2.6 > >branch and this branch. It looks like it improves speed, although the > >difference is pretty much negligible: > > > >master: 2m25 2m28 2m26 2m26 2m26 > >ppc-for-2.6: 2m26 2m25 2m26 2m27 2m25 > >this series: 2m20 2m23 2m23 2m25 2m21 > > > >Please review, and I'll fold into ppc-for-2.6 for my next pull. > > > >Changes since v1: > > * Fix a couple of simple but serious bugs in logic > > * Did some rudimentary benchmarking > >Changes since RFC: > > * Moved lookup of SLB encodings table from SLB lookup time to SLB > > store time >=20 > LGTM, apart from the comments that people already made. Please also provi= de > changelogs in the individual patch files next time - it makes it easier f= or > people who just try to see what changed from one version to another ;). >=20 > Reviewed-by: Alexander Graf Thanks, I've merged to ppc-for-2.6. > Also, please just double sanity check that the code after your conversion > still works well on 32bit hosts ;). I suppose you have a 32bit build > environment by now, so that should be quite easy to pull off. Yeah, will do. I'm still pretty pissed that glib breaks the multiarch build, which should be straightforward, but I have something workable. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vKFfOv5t3oGVpiF+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWqtAkAAoJEGw4ysog2bOSVKIQAOMYro8M7htmyhiXHN8Mv82w Q6F0PeCNySK17jBe1+bXQHrM54TO+BomM/x6U69VR0bCi2H1I6BgQCwfL/6E0UTF 8Yu+4j/a3FqBlMctYsy7mIJL6+0e7gD2yNim4yiql9hzIZS3pgtlfqlZu9os3vCz apJzCJxf9n/Tz0sXOkFGglZDSPIX7pdRmhMMGQBlHPP4hXwSr2KKM3JRxHs828H0 iLcSbV7AU7RpXKMH2czDt7ZI+p8/Irk0UZHheE8UcHJZSG7b6c31awruzHxvlHZE uwsU0/am6B3ASOWIFbGyjjrUvK1atc01MRUaWzRUtAL97j7EZ2CkJt/dMe0RmgQ0 UzCyZIh5WX8iksmsSYI16Q5LbqDKAVnWS9hiqdM+5dnW4CVzd25+WRQFWfyFWJfb XIfcivs5pjFhjR3UxRtR0wjlmKyvczttOl/aRoGabeRIfwwGENPpy1RO4ni51BI2 RztOuoFFLZnBAkpBVvs7OwuHkWGPqRxwp9hSLwR7DKr02skspKj54w+753qFsGFg BZ8u3EKU8mCH3rca+ydjWKRnaYTMGyvlbMvtWuwROvQq88Gn49IMmd3ky6AQcKpi uEzvwPTRef/mCTqCZ6VhcousH9EmxIalmLWNvUbNwim2h8VzmX4S1smD2csqi3lV 5pepSpCvZwxSAUSJG01N =DXnn -----END PGP SIGNATURE----- --vKFfOv5t3oGVpiF+--