From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aP42Q-0005eb-Js for qemu-devel@nongnu.org; Fri, 29 Jan 2016 03:04:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aP42P-0003va-Ao for qemu-devel@nongnu.org; Fri, 29 Jan 2016 03:04:14 -0500 Date: Fri, 29 Jan 2016 09:02:47 +0100 From: Aurelien Jarno Message-ID: <20160129080247.GA15397@aurel32.net> References: <1454044031-5930-1-git-send-email-david@gibson.dropbear.id.au> <1454044031-5930-5-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454044031-5930-5-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 03/39] macio: use the existing IDEDMA aiocb to hold the active DMA aiocb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, mdroth@linux.vnet.ibm.com On 2016-01-29 16:06, David Gibson wrote: > From: Mark Cave-Ayland > > Currently the aiocb is held within MACIOIDEState, however the IDE core code > assumes that the current actvie DMA aiocb is held in aiocb in a few places, > e.g. ide_bus_reset() and ide_reset(). > > Switch over to using IDEDMA aiocb to store the aiocb for the current active > DMA request so that bus resets and restarts are handled correctly. As a > consequence we can now use ide_set_inactive() rather than handling its > functionality ourselves. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: John Snow > Signed-off-by: David Gibson > --- > hw/ide/macio.c | 20 +- > hw/ide/macio.c.orig | 634 ++++++++++++++++++++++++++++++++++++++++++++++++++++ I don't think you want to add this file to the git. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net