From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbcA2Oup (ORCPT ); Fri, 29 Jan 2016 09:50:45 -0500 Received: from mga01.intel.com ([192.55.52.88]:42067 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756092AbcA2Oun (ORCPT ); Fri, 29 Jan 2016 09:50:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,364,1449561600"; d="scan'208";a="891892329" Date: Fri, 29 Jan 2016 09:50:40 -0500 From: Matthew Wilcox To: Vlastimil Babka Cc: Matthew Wilcox , Andrew Morton , Hugh Dickins , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() Message-ID: <20160129145040.GW2948@linux.intel.com> References: <1453929472-25566-1-git-send-email-matthew.r.wilcox@intel.com> <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> <56AB7B27.3090805@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56AB7B27.3090805@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 03:45:59PM +0100, Vlastimil Babka wrote: > This should be applied on top. There are no restarts anymore. Quite right. Sorry I missed the comment. Acked-by: Matthwe Wilcox > ----8<---- > >From 3b0bdd370b57fb6d83b213e140cd1fb0e8962af8 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Fri, 29 Jan 2016 15:41:31 +0100 > Subject: [PATCH] mm: Use radix_tree_iter_retry()-fix > > Remove now-obsolete-and-misleading comment. > > Signed-off-by: Vlastimil Babka > --- > mm/shmem.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 8f89abd4eaee..4d758938340c 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -382,11 +382,6 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, > > page = radix_tree_deref_slot(slot); > > - /* > - * This should only be possible to happen at index 0, so we > - * don't need to reset the counter, nor do we risk infinite > - * restarts. > - */ > if (radix_tree_deref_retry(page)) { > slot = radix_tree_iter_retry(&iter); > continue; > -- > 2.7.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 29 Jan 2016 09:50:40 -0500 From: Matthew Wilcox To: Vlastimil Babka Cc: Matthew Wilcox , Andrew Morton , Hugh Dickins , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() Message-ID: <20160129145040.GW2948@linux.intel.com> References: <1453929472-25566-1-git-send-email-matthew.r.wilcox@intel.com> <1453929472-25566-5-git-send-email-matthew.r.wilcox@intel.com> <56AB7B27.3090805@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56AB7B27.3090805@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: On Fri, Jan 29, 2016 at 03:45:59PM +0100, Vlastimil Babka wrote: > This should be applied on top. There are no restarts anymore. Quite right. Sorry I missed the comment. Acked-by: Matthwe Wilcox > ----8<---- > >From 3b0bdd370b57fb6d83b213e140cd1fb0e8962af8 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Fri, 29 Jan 2016 15:41:31 +0100 > Subject: [PATCH] mm: Use radix_tree_iter_retry()-fix > > Remove now-obsolete-and-misleading comment. > > Signed-off-by: Vlastimil Babka > --- > mm/shmem.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 8f89abd4eaee..4d758938340c 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -382,11 +382,6 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, > > page = radix_tree_deref_slot(slot); > > - /* > - * This should only be possible to happen at index 0, so we > - * don't need to reset the counter, nor do we risk infinite > - * restarts. > - */ > if (radix_tree_deref_retry(page)) { > slot = radix_tree_iter_retry(&iter); > continue; > -- > 2.7.0 > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org