From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756745AbcA2VAP (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 16:00:15 -0500
Received: from mail.kernel.org ([198.145.29.136]:33340 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752157AbcA2VAN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 16:00:13 -0500
Date: Fri, 29 Jan 2016 18:00:08 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains
 (v2)
Message-ID: <20160129210008.GA32225@kernel.org>
References: <1453909257-26015-1-git-send-email-namhyung@kernel.org>
 <20160128081611.GC2322@krava.brq.redhat.com>
 <CAM9d7cjCHLrYNwFQn4zA-X8Lu9owTL691oLxyt-zWubwZu2mzg@mail.gmail.com>
 <CAM9d7cgqPMJe9RAf89aLoGaZWzNsjioymqARZnB4h48dvvJZ1g@mail.gmail.com>
 <20160128121245.GA17708@krava.brq.redhat.com>
 <20160128122454.GA27446@danjae.kornet>
 <20160128195225.GB12456@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160128195225.GB12456@krava.brq.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Jan 28, 2016 at 08:52:25PM +0100, Jiri Olsa escreveu:
> On Thu, Jan 28, 2016 at 09:24:54PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > > > > The default limit of hist entries is 0 so it basically shows all
> > > > > entries.  But default callchain limit is 0.5% so hist entries under
> > > > > 0.5% won't show callchains.
> > > > 
> > > > Btw, I changed it to 0.005% in this patchset.  Did you apply all the
> > > > patches and run 'perf report' with default value?
> > > 
> > > yep, I had it and then reverted ;-) but I made typo
> > > in the previous email.. what I meant was:
> > > 
> > > also I see extra LINE for entries...  ;-)
> > 
> > Ah, so you meant the blank lines..  The fix would be like following
> 
> yep, tested.. works ;-)

Namhyung, can I try to process this patchkit just by reading these
commends and making the adjustments? Or is there something outstanding
that warrants you to push a v2?

- Arnaldo