From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPl1B-0006we-2c for qemu-devel@nongnu.org; Sun, 31 Jan 2016 00:57:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPl17-0003ql-TU for qemu-devel@nongnu.org; Sun, 31 Jan 2016 00:57:49 -0500 Date: Sat, 30 Jan 2016 23:36:00 +1100 From: David Gibson Message-ID: <20160130123600.GR23043@voom.redhat.com> References: <1454044031-5930-1-git-send-email-david@gibson.dropbear.id.au> <1454044031-5930-5-git-send-email-david@gibson.dropbear.id.au> <20160129080247.GA15397@aurel32.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="562f9N4fbIs+fPrJ" Content-Disposition: inline In-Reply-To: <20160129080247.GA15397@aurel32.net> Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 03/39] macio: use the existing IDEDMA aiocb to hold the active DMA aiocb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, mdroth@linux.vnet.ibm.com --562f9N4fbIs+fPrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 29, 2016 at 09:02:47AM +0100, Aurelien Jarno wrote: > On 2016-01-29 16:06, David Gibson wrote: > > From: Mark Cave-Ayland > >=20 > > Currently the aiocb is held within MACIOIDEState, however the IDE core = code > > assumes that the current actvie DMA aiocb is held in aiocb in a few pla= ces, > > e.g. ide_bus_reset() and ide_reset(). > >=20 > > Switch over to using IDEDMA aiocb to store the aiocb for the current ac= tive > > DMA request so that bus resets and restarts are handled correctly. As a > > consequence we can now use ide_set_inactive() rather than handling its > > functionality ourselves. > >=20 > > Signed-off-by: Mark Cave-Ayland > > Reviewed-by: John Snow > > Signed-off-by: David Gibson > > --- > > hw/ide/macio.c | 20 +- > > hw/ide/macio.c.orig | 634 ++++++++++++++++++++++++++++++++++++++++++++= ++++++++ >=20 > I don't think you want to add this file to the git. Sigh. Indeed. Not doing well with these pulls lately :(. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --562f9N4fbIs+fPrJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWrK4wAAoJEGw4ysog2bOSHp4P/33L4s2Pi9Ya7pP0Vdzlt+4O SoQrDCA5eeq2F4sFBOLy8mwFV9bWj8/86f2rT7EKzbwr/VRRQNgKzWdWQJHdur8b CwJIGxXAEcJliwkOlNWWQn3rX0NkedSpvs9E+N3B8KHJAUG0WIkfsaQo/uHc/cPS zqQKeTTPs/BvCNl5WrmbtZYRyR+OeW553IQ+wEA04eOEISrWOMDyz82MXpwu4Dty oaIZX5w9gI3X7UunxZUWPJ5/HZnSkXqd5O0aw/mvBcmTCSB3EkTkkgwbd3Ocq8Sd 7q/Ygh7xhWXzxCaleDs0XiNDeUYI3Q+DsNiowt+aWtJxmH7bAI/O9lHdW4Gd7oNf 4nZ1T7c0DiGzBsrcxwMy5D8XQl4e7TGtBWkaF5F1u9GQaD0btgo44izYsp508lrI YrzyT0fbWQ6TmqP9XHJ4h1X1xHkmKvxwMLyicmLqzsa7fNCgNfR2ElA0MG3Fczur nzdXvCsSDtpFvWimMDi/0Y1cUt73YCR5o9YSDQjPPnH3GuE+xiIyiWCv0aMPK6tP 2jNhEz3v6UKsrCBVqLYcE8gLidB4mC4lf+LPfGbqH/6Sd6s1CPzjiK1ZiOFehr5s IcTjWezx9LC/h4xHTdGlXimxC6xCcQGL8PpsuchXHao6Axuqo3FQsAoKeL/8gkec j1h+20UFyGW/MUJ7jRtD =2ZEr -----END PGP SIGNATURE----- --562f9N4fbIs+fPrJ--