All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL
Date: Sun, 31 Jan 2016 18:25:58 +0100	[thread overview]
Message-ID: <201601311825.58774.marex@denx.de> (raw)
In-Reply-To: <20160124233000.GY3359@bill-the-cat>

On Monday, January 25, 2016 at 12:30:00 AM, Tom Rini wrote:
> On Mon, Jan 25, 2016 at 12:00:05AM +0100, Marek Vasut wrote:
> > On Sunday, January 24, 2016 at 11:21:51 PM, Tom Rini wrote:
> > > On Sun, Jan 24, 2016 at 11:07:30PM +0100, Marek Vasut wrote:
> > > > On Sunday, January 24, 2016 at 08:33:57 PM, Tom Rini wrote:
> > > > > On Sun, Jan 24, 2016 at 06:22:10PM +0100, Marek Vasut wrote:
> > > > > > On Sunday, January 24, 2016 at 06:18:23 PM, Stefano Babic wrote:
> > > > > > > On 24/01/2016 18:11, Marek Vasut wrote:
> > > > > > > > It is not clear when the wait_for_bit() will be applied, I am
> > > > > > > > certain there will be another round for so. I do not want to
> > > > > > > > wait for it and I don't see a reason why those patches should
> > > > > > > > block this if the conversion can be done afterward.
> > > > > > > 
> > > > > > > Just wait for a while - if it takes too much, I reconsider to
> > > > > > > apply this first and factorize wait_for_bit() in a follow-up
> > > > > > > patch.
> > > > > > 
> > > > > > I have waited for over a month and I fail to see a reason why
> > > > > > patches which will be applied at uncertain point in the future
> > > > > > shall block this patchset. The wait_for_bit() can be removed by
> > > > > > a subsequent patch, it is already pulled out explicitly in the
> > > > > > code, so I don't see a problem with applying this.
> > > > > 
> > > > > Did I miss something or isn't v4 of wait_for_bit good to go?
> > > > 
> > > > I don't really know if it's good to go, but this patch does not
> > > > depend on it in any way. A subsequent patch can drop the
> > > > wait_for_bit() from here, it's the same as the wait_for_bit() in
> > > > dwc2 and other wait_for_bit() anywhere else, but I don't see a
> > > > reason why this patch should not be applied now.
> > > > 
> > > > If I follow the logic in this thread, it would also be possible to
> > > > say that this patch should wait until Eric submits the MX6S DDR
> > > > support for example. We could indefinitelly wait for new and new
> > > > stuff which might possibly block this.
> > > 
> > > Why don't you ack/test/review the wait_for_bit series and post a
> > > follow-up to this one that uses the common function, which can be
> > > squashed into the original and then this gets picked up?
> > 
> > Why ? I can send subsequent patch which removes the duplicate
> > wait_for_bit() from this code once the wait_for_bit series is applied. I
> > don't see a problem with that and the wait_for_bit() being so explicitly
> > pulled out from the code is done with that in mind. But that does not
> > block this patch from being applied now. Does it?
> 
> If I tell you I'm probably going to have the wait_for_bit stuff applied
> before the next imx PR is ready... ?

So, why is this patchset not applied yet ... ?

Best regards,
Marek Vasut

  parent reply	other threads:[~2016-01-31 17:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 14:40 [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL Marek Vasut
2015-12-16 14:40 ` [U-Boot] [PATCH 2/2] arm: imx6: Enable DDR calibration on Novena Marek Vasut
2015-12-20 19:46   ` Eric Nelson
     [not found]   ` <567702A6.9070107@cox.net>
2015-12-22  1:26     ` Marek Vasut
2015-12-22  8:30       ` Nikolay Dimitrov
2015-12-22 14:56         ` Marek Vasut
2015-12-16 15:00 ` [U-Boot] [PATCH 1/2] arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL Eric Nelson
2015-12-16 15:33   ` Marek Vasut
2015-12-16 16:28     ` Eric Nelson
2015-12-16 16:50       ` Marek Vasut
2015-12-16 17:07         ` Eric Nelson
2015-12-16 17:11           ` Marek Vasut
2015-12-17 15:39   ` Tim Harvey
2015-12-17 15:48     ` Eric Nelson
2015-12-17 15:36 ` Tim Harvey
2015-12-17 15:40   ` Marek Vasut
2015-12-17 16:15     ` Tim Harvey
2015-12-17 16:17       ` Marek Vasut
2015-12-17 21:32 ` Nikolay Dimitrov
2015-12-17 22:11   ` Marek Vasut
2015-12-20 19:31 ` Eric Nelson
2015-12-22  1:52   ` Marek Vasut
2015-12-22 15:37     ` Eric Nelson
2016-01-14  2:10       ` Marek Vasut
2016-01-14  2:37         ` Eric Nelson
2016-01-14  2:50           ` Marek Vasut
2016-01-14  2:52             ` Eric Nelson
2016-01-14  3:06               ` Marek Vasut
2016-01-14 14:25                 ` Tim Harvey
2016-01-24 10:47                   ` Stefano Babic
2016-01-24 16:01                     ` Marek Vasut
2016-01-24 17:03                       ` Stefano Babic
2016-01-24 17:11                         ` Marek Vasut
2016-01-24 17:18                           ` Stefano Babic
2016-01-24 17:22                             ` Marek Vasut
2016-01-24 19:33                               ` Tom Rini
2016-01-24 22:07                                 ` Marek Vasut
2016-01-24 22:21                                   ` Tom Rini
2016-01-24 23:00                                     ` Marek Vasut
2016-01-24 23:30                                       ` Tom Rini
2016-01-24 23:55                                         ` Marek Vasut
2016-01-31 17:25                                         ` Marek Vasut [this message]
2016-06-02 13:20                                           ` Tim Harvey
2016-06-02 14:23                                             ` Stefano Babic
2016-06-02 15:25                                               ` Tim Harvey
2015-12-22  4:13   ` Tim Harvey
2015-12-22 14:47     ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601311825.58774.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.