diff for duplicates of <20160201085950.GA3368@x1>
diff --git a/a/1.txt b/N1/1.txt
index 98e6d93..82001b6 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -80,8 +80,4 @@ and passing it through the OF .data attribute.
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
-Follow Linaro: Facebook | Twitter | Blog
---
-To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
-the body of a message to majordomo@vger.kernel.org
-More majordomo info at http://vger.kernel.org/majordomo-info.html
\ No newline at end of file
+Follow Linaro: Facebook | Twitter | Blog
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 1138088..82f1d1f 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -133,11 +133,7 @@
"Lee Jones\n",
"Linaro STMicroelectronics Landing Team Lead\n",
"Linaro.org \342\224\202 Open source software for ARM SoCs\n",
- "Follow Linaro: Facebook | Twitter | Blog\n",
- "--\n",
- "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n",
- "the body of a message to majordomo\@vger.kernel.org\n",
- "More majordomo info at http://vger.kernel.org/majordomo-info.html"
+ "Follow Linaro: Facebook | Twitter | Blog"
]
-5a7056011e449faf01603582d492ec1be306422b2b953c16c5d009a1518b8d2f
+16f5cdce7ae15f7b223d4138ddb0c4dbf9b4230cc874306da35510784a7ca29f
diff --git a/a/1.txt b/N2/1.txt
index 98e6d93..d571664 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -2,7 +2,7 @@ On Fri, 29 Jan 2016, Laxman Dewangan wrote:
> Thanks Lee for review.
> I will take care of most of stuff on next version of patch.
->
+>=20
> However, I have some query form your comment.
> On Friday 29 January 2016 02:36 PM, Lee Jones wrote:
> >On Thu, 28 Jan 2016, Laxman Dewangan wrote:
@@ -11,33 +11,33 @@ On Fri, 29 Jan 2016, Laxman Dewangan wrote:
> >>+ }
> >>+
> >>+#define MAX20024_SUB_MODULE_NO_RES(_name, _id) \
-> >>+ [_id] = { \
-> >>+ .name = "max20024-"#_name, \
-> >>+ .id = _id, \
+> >>+ [_id] =3D { \
+> >>+ .name =3D "max20024-"#_name, \
+> >>+ .id =3D _id, \
> >>+ }
> >I don't want people hand-rolling this stuff. If it's useful to you,
> >it's useful to others, so great a generic implementation that lives in
> >the kernel headers directory.
->
+>=20
> yaah, generic implementation possible. I can put the new defines in
> the mfd/core.h.
->
+>=20
> This will be similar to
> +/* Define mfd cells with name and resource */
> +#define DEFINE_MFD_CELL_NAME_RESOURCE(_name, _res) \
> + { \
-> + .name = (_name), \
-> + .num_resources = ARRAY_SIZE((res)), \
-> + .resources = (_res), \
+> + .name =3D (_name), \
+> + .num_resources =3D ARRAY_SIZE((res)), \
+> + .resources =3D (_res), \
> + }
> +
> +/* Define mfd cells with name */
> +#define DEFINE_MFD_CELL_NAME(_name) \
> + { \
-> + .name = (_name), \
+> + .name =3D (_name), \
> + }
> +
->
+>=20
> This will be separate patch and should be applied before this series.
> Does it look fine?
@@ -45,43 +45,52 @@ Hmm... Actually, I have my own ideas of how this should look. How do
you feel about me submitting my own patch. I'll keep you on Cc, so
you can review and make use of it in your set.
-> >>+static const struct i2c_device_id max77620_id[] = {
+> >>+static const struct i2c_device_id max77620_id[] =3D {
> >>+ {"max77620", MAX77620},
> >>+ {"max20024", MAX20024},
> >>+ {},
> >>+};
> >>+MODULE_DEVICE_TABLE(i2c, max77620_id);
> >>+
-> >>+static const struct of_device_id max77620_of_match[] = {
+> >>+static const struct of_device_id max77620_of_match[] =3D {
> >>+ {
-> >>+ .compatible = "maxim,max77620",
-> >>+ .data = &max77620_cells,
+> >>+ .compatible =3D "maxim,max77620",
+> >>+ .data =3D &max77620_cells,
> >>+ }, {
-> >>+ .compatible = "maxim,max20024",
-> >>+ .data = &max20024_cells,
+> >>+ .compatible =3D "maxim,max20024",
+> >>+ .data =3D &max20024_cells,
> >>+ }, {
> >>+ },
> >>+};
> >>+MODULE_DEVICE_TABLE(of, max77620_of_match);
> >This is not acceptable. EITHER use DT OR MFD methods of registering
> >devices, do not mix the two.
->
+>=20
> You mean I need to either provide the i2c_device_id table or the
> of_device_id table, not both?
> Do I need to protect it by CONFIG_OF?
->
+>=20
> This only support the DT method of registration. So do I need to
> remove i2c_device_id?
No, I mean I don't want you providing platform data via an MFD cell
and passing it through the OF .data attribute.
---
+--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
-Linaro.org │ Open source software for ARM SoCs
+Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
---
-To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
-the body of a message to majordomo@vger.kernel.org
-More majordomo info at http://vger.kernel.org/majordomo-info.html
\ No newline at end of file
+
+--=20
+--=20
+You received this message because you are subscribed to "rtc-linux".
+Membership options at http://groups.google.com/group/rtc-linux .
+Please read http://groups.google.com/group/rtc-linux/web/checklist
+before submitting a driver.
+---=20
+You received this message because you are subscribed to the Google Groups "=
+rtc-linux" group.
+To unsubscribe from this group and stop receiving emails from it, send an e=
+mail to rtc-linux+unsubscribe@googlegroups.com.
+For more options, visit https://groups.google.com/d/optout.
\ No newline at end of file
diff --git a/a/content_digest b/N2/content_digest
index 1138088..b408b33 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -14,7 +14,7 @@
"From\0Lee Jones <lee.jones\@linaro.org>\0"
]
[
- "Subject\0Re: [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024\0"
+ "Subject\0[rtc-linux] Re: [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024\0"
]
[
"Date\0Mon, 1 Feb 2016 08:59:50 +0000\0"
@@ -55,7 +55,7 @@
"\n",
"> Thanks Lee for review.\n",
"> I will take care of most of stuff on next version of patch.\n",
- "> \n",
+ ">=20\n",
"> However, I have some query form your comment.\n",
"> On Friday 29 January 2016 02:36 PM, Lee Jones wrote:\n",
"> >On Thu, 28 Jan 2016, Laxman Dewangan wrote:\n",
@@ -64,33 +64,33 @@
"> >>+\t}\n",
"> >>+\n",
"> >>+#define MAX20024_SUB_MODULE_NO_RES(_name, _id)\t\t\t\\\n",
- "> >>+\t[_id] = {\t\t\t\t\t\t\\\n",
- "> >>+\t\t.name = \"max20024-\"#_name,\t\t\t\\\n",
- "> >>+\t\t.id = _id,\t\t\t\t\t\\\n",
+ "> >>+\t[_id] =3D {\t\t\t\t\t\t\\\n",
+ "> >>+\t\t.name =3D \"max20024-\"#_name,\t\t\t\\\n",
+ "> >>+\t\t.id =3D _id,\t\t\t\t\t\\\n",
"> >>+\t}\n",
"> >I don't want people hand-rolling this stuff. If it's useful to you,\n",
"> >it's useful to others, so great a generic implementation that lives in\n",
"> >the kernel headers directory.\n",
- "> \n",
+ ">=20\n",
"> yaah, generic implementation possible. I can put the new defines in\n",
"> the mfd/core.h.\n",
- "> \n",
+ ">=20\n",
"> This will be similar to\n",
"> +/* Define mfd cells with name and resource */\n",
"> +#define DEFINE_MFD_CELL_NAME_RESOURCE(_name, _res) \\\n",
"> + { \\\n",
- "> + .name = (_name), \\\n",
- "> + .num_resources = ARRAY_SIZE((res)), \\\n",
- "> + .resources = (_res), \\\n",
+ "> + .name =3D (_name), \\\n",
+ "> + .num_resources =3D ARRAY_SIZE((res)), \\\n",
+ "> + .resources =3D (_res), \\\n",
"> + }\n",
"> +\n",
"> +/* Define mfd cells with name */\n",
"> +#define DEFINE_MFD_CELL_NAME(_name) \\\n",
"> + { \\\n",
- "> + .name = (_name), \\\n",
+ "> + .name =3D (_name), \\\n",
"> + }\n",
"> +\n",
- "> \n",
+ ">=20\n",
"> This will be separate patch and should be applied before this series.\n",
"> Does it look fine?\n",
"\n",
@@ -98,46 +98,55 @@
"you feel about me submitting my own patch. I'll keep you on Cc, so\n",
"you can review and make use of it in your set.\n",
"\n",
- "> >>+static const struct i2c_device_id max77620_id[] = {\n",
+ "> >>+static const struct i2c_device_id max77620_id[] =3D {\n",
"> >>+\t{\"max77620\", MAX77620},\n",
"> >>+\t{\"max20024\", MAX20024},\n",
"> >>+\t{},\n",
"> >>+};\n",
"> >>+MODULE_DEVICE_TABLE(i2c, max77620_id);\n",
"> >>+\n",
- "> >>+static const struct of_device_id max77620_of_match[] = {\n",
+ "> >>+static const struct of_device_id max77620_of_match[] =3D {\n",
"> >>+\t{\n",
- "> >>+\t\t.compatible = \"maxim,max77620\",\n",
- "> >>+\t\t.data = &max77620_cells,\n",
+ "> >>+\t\t.compatible =3D \"maxim,max77620\",\n",
+ "> >>+\t\t.data =3D &max77620_cells,\n",
"> >>+\t}, {\n",
- "> >>+\t\t.compatible = \"maxim,max20024\",\n",
- "> >>+\t\t.data = &max20024_cells,\n",
+ "> >>+\t\t.compatible =3D \"maxim,max20024\",\n",
+ "> >>+\t\t.data =3D &max20024_cells,\n",
"> >>+\t}, {\n",
"> >>+\t},\n",
"> >>+};\n",
"> >>+MODULE_DEVICE_TABLE(of, max77620_of_match);\n",
"> >This is not acceptable. EITHER use DT OR MFD methods of registering\n",
"> >devices, do not mix the two.\n",
- "> \n",
+ ">=20\n",
"> You mean I need to either provide the i2c_device_id table or the\n",
"> of_device_id table, not both?\n",
"> Do I need to protect it by CONFIG_OF?\n",
- "> \n",
+ ">=20\n",
"> This only support the DT method of registration. So do I need to\n",
"> remove i2c_device_id?\n",
"\n",
"No, I mean I don't want you providing platform data via an MFD cell\n",
"and passing it through the OF .data attribute.\n",
"\n",
- "-- \n",
+ "--=20\n",
"Lee Jones\n",
"Linaro STMicroelectronics Landing Team Lead\n",
- "Linaro.org \342\224\202 Open source software for ARM SoCs\n",
+ "Linaro.org =E2=94=82 Open source software for ARM SoCs\n",
"Follow Linaro: Facebook | Twitter | Blog\n",
- "--\n",
- "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n",
- "the body of a message to majordomo\@vger.kernel.org\n",
- "More majordomo info at http://vger.kernel.org/majordomo-info.html"
+ "\n",
+ "--=20\n",
+ "--=20\n",
+ "You received this message because you are subscribed to \"rtc-linux\".\n",
+ "Membership options at http://groups.google.com/group/rtc-linux .\n",
+ "Please read http://groups.google.com/group/rtc-linux/web/checklist\n",
+ "before submitting a driver.\n",
+ "---=20\n",
+ "You received this message because you are subscribed to the Google Groups \"=\n",
+ "rtc-linux\" group.\n",
+ "To unsubscribe from this group and stop receiving emails from it, send an e=\n",
+ "mail to rtc-linux+unsubscribe\@googlegroups.com.\n",
+ "For more options, visit https://groups.google.com/d/optout."
]
-5a7056011e449faf01603582d492ec1be306422b2b953c16c5d009a1518b8d2f
+d8b9ed7cf4f226c26a669b875c8ef60ba5057c923d579e9aa845c24e4271674c
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.