From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246AbcBAU44 (ORCPT ); Mon, 1 Feb 2016 15:56:56 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35620 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753092AbcBAU4z (ORCPT ); Mon, 1 Feb 2016 15:56:55 -0500 Date: Mon, 1 Feb 2016 12:56:48 -0800 From: Joshua Clayton To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/8] rtc: implement a sysfs interface for clock offset Message-ID: <20160201125648.37475997@jclayton-pc> In-Reply-To: <20160131114115.GJ20165@piout.net> References: <0000-cover-letter.patch> <8361752a4e0c524e15cbed36d03eb3eb9b187815.1451929910.git.stillcompiling@gmail.com> <20160131114115.GJ20165@piout.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Jan 2016 12:41:15 +0100 Alexandre Belloni wrote: > Hi, > > On 04/01/2016 at 10:31:25 -0800, Joshua Clayton wrote : > > The file is called "offset", and may be set and read in decimal. > > For rtcs that do not have read_offset or set_offset implemented, > > read always returns zero and write will return -EINVAL. > > > Can you expand rtc_attr_is_visible() instead of having the offset file > always present? Yes, Absolutely. I wanted to do something like this, but didn't know is_visible existed... and no wonder. Its in attribute_group > > Also, you need to expand Documentation/rtc.txt, section SYSFS > INTERFACE. > OK. Will do. > I'm fine with having parts per billion as the unit and I hope we won't > ever need anything more precise :) > It is orders of magnitude more than needed at present ...and no will ever need more than 640k of memory... right? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com. [2607:f8b0:400e:c00::243]) by gmr-mx.google.com with ESMTPS id jg4si3561805pac.2.2016.02.01.12.56.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 12:56:55 -0800 (PST) Received: by mail-pf0-x243.google.com with SMTP id 65so7974890pfd.1 for ; Mon, 01 Feb 2016 12:56:55 -0800 (PST) Date: Mon, 1 Feb 2016 12:56:48 -0800 From: Joshua Clayton To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v2 7/8] rtc: implement a sysfs interface for clock offset Message-ID: <20160201125648.37475997@jclayton-pc> In-Reply-To: <20160131114115.GJ20165@piout.net> References: <0000-cover-letter.patch> <8361752a4e0c524e15cbed36d03eb3eb9b187815.1451929910.git.stillcompiling@gmail.com> <20160131114115.GJ20165@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Sun, 31 Jan 2016 12:41:15 +0100 Alexandre Belloni wrote: > Hi, > > On 04/01/2016 at 10:31:25 -0800, Joshua Clayton wrote : > > The file is called "offset", and may be set and read in decimal. > > For rtcs that do not have read_offset or set_offset implemented, > > read always returns zero and write will return -EINVAL. > > > Can you expand rtc_attr_is_visible() instead of having the offset file > always present? Yes, Absolutely. I wanted to do something like this, but didn't know is_visible existed... and no wonder. Its in attribute_group > > Also, you need to expand Documentation/rtc.txt, section SYSFS > INTERFACE. > OK. Will do. > I'm fine with having parts per billion as the unit and I hope we won't > ever need anything more precise :) > It is orders of magnitude more than needed at present ...and no will ever need more than 640k of memory... right? -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.