From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754383AbcBBCfK (ORCPT ); Mon, 1 Feb 2016 21:35:10 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:44812 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754074AbcBBCfI (ORCPT ); Mon, 1 Feb 2016 21:35:08 -0500 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Tue, 2 Feb 2016 11:34:36 +0900 From: Byungchul Park To: Ingo Molnar Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, akinobu.mita@gmail.com, jack@suse.cz, sergey.senozhatsky.work@gmail.com, peter@hurleysoftware.com, torvalds@linux-foundation.org Subject: Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in the debug code Message-ID: <20160202023436.GG29804@X58A-UD3R> References: <1454071417-20685-1-git-send-email-byungchul.park@lge.com> <20160130092743.GA13745@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160130092743.GA13745@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2016 at 10:27:43AM +0100, Ingo Molnar wrote: > > * Byungchul Park wrote: > > > + > > + /* > > + * If this function is called from printk(), then we should > > + * not call printk() more. Or it will cause an infinite > > + * recursive cycle! > > This should be something like: > > > + * If this function is called from within printk() then we > > + * should not call printk() again, or it will recurse > > + * infinitely. > > Thanks, Thank you very much. Not easy to me. > > Ingo