From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755046AbcBBNGs (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 08:06:48 -0500
Received: from mail-pf0-f194.google.com ([209.85.192.194]:33558 "EHLO
	mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754884AbcBBNGq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 08:06:46 -0500
Date: Tue, 2 Feb 2016 22:05:37 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains
 also
Message-ID: <20160202130537.GA4153@danjae.kornet>
References: <1453909257-26015-1-git-send-email-namhyung@kernel.org>
 <1453909257-26015-4-git-send-email-namhyung@kernel.org>
 <20160201201936.GC20817@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160201201936.GC20817@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnaldo,

On Mon, Feb 01, 2016 at 05:19:36PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 28, 2016 at 12:40:50AM +0900, Namhyung Kim escreveu:
> > Currently --percent-limit option only works for hist entries.  However
> > it'd be better to have same effect to callchains as well
> 
> Documentation needs updating? It says:
> 
> --percent-limit::
>         Do not show entries which have an overhead under that percent.
>         (Default: 0).

Right.  Is it ok to you?

--percent-limit::
        Do not show entries and callchains which have an overhead under that
        percent.  (Default: 0).


Thanks,
Namhyung


> 
>  
> > Requested-by: Andi Kleen <andi@firstfloor.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> >  tools/perf/builtin-report.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index 2bf537f190a0..72ed0b46d5a1 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -75,7 +75,10 @@ static int report__config(const char *var, const char *value, void *cb)
> >  		return 0;
> >  	}
> >  	if (!strcmp(var, "report.percent-limit")) {
> > -		rep->min_percent = strtof(value, NULL);
> > +		double pcnt = strtof(value, NULL);
> > +
> > +		rep->min_percent = pcnt;
> > +		callchain_param.min_percent = pcnt;
> >  		return 0;
> >  	}
> >  	if (!strcmp(var, "report.children")) {
> > @@ -633,8 +636,10 @@ parse_percent_limit(const struct option *opt, const char *str,
> >  		    int unset __maybe_unused)
> >  {
> >  	struct report *rep = opt->value;
> > +	double pcnt = strtof(str, NULL);
> >  
> > -	rep->min_percent = strtof(str, NULL);
> > +	rep->min_percent = pcnt;
> > +	callchain_param.min_percent = pcnt;
> >  	return 0;
> >  }
> >  
> > -- 
> > 2.6.4