From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932642AbcBBO6E (ORCPT ); Tue, 2 Feb 2016 09:58:04 -0500 Received: from mail.kernel.org ([198.145.29.136]:59624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbcBBO6C (ORCPT ); Tue, 2 Feb 2016 09:58:02 -0500 Date: Tue, 2 Feb 2016 11:57:54 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , David Ahern , Frederic Weisbecker , Wang Nan Subject: Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains also Message-ID: <20160202145754.GC32488@kernel.org> References: <1453909257-26015-1-git-send-email-namhyung@kernel.org> <1453909257-26015-4-git-send-email-namhyung@kernel.org> <20160201201936.GC20817@kernel.org> <20160202130537.GA4153@danjae.kornet> <20160202135534.GB29970@kernel.org> <20160202141535.GA4627@danjae.kornet> <20160202142734.GB32488@kernel.org> <20160202143513.GB4627@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160202143513.GB4627@danjae.kornet> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 02, 2016 at 11:35:13PM +0900, Namhyung Kim escreveu: > On Tue, Feb 02, 2016 at 11:27:34AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Feb 02, 2016 at 11:15:35PM +0900, Namhyung Kim escreveu: > > > On Tue, Feb 02, 2016 at 10:55:34AM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Feb 02, 2016 at 10:05:37PM +0900, Namhyung Kim escreveu: > > > > > Hi Arnaldo, > > > > > > > > > > On Mon, Feb 01, 2016 at 05:19:36PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > Em Thu, Jan 28, 2016 at 12:40:50AM +0900, Namhyung Kim escreveu: > > > > > > > Currently --percent-limit option only works for hist entries. However > > > > > > > it'd be better to have same effect to callchains as well > > > > > > > > > > > > Documentation needs updating? It says: > > > > > > > > > > > > --percent-limit:: > > > > > > Do not show entries which have an overhead under that percent. > > > > > > (Default: 0). > > > > > > > > > > Right. Is it ok to you? > > > > > > > > > > --percent-limit:: > > > > > Do not show entries and callchains which have an overhead under that > > > > > percent. (Default: 0). > > > > > > > > Ok, but is the default zero? > > > > > > > > That was what I was alluding to, as as soon as I applied the patch that > > > > made callchains honour this limit, about 60% of the entries in the > > > > particular perf.data file I was 'perf report'ing lost its '+' (callchain > > > > expansion) signs. > > > > > > Yes, and this is what I want to say too. :) > > > > > > The default value of percent limit is different for hist entry and > > > callchains. For hist entry the default is 0, and for callchains it's > > > 0.5%. But using --percent-limit option, we can set both at once from > > > now on. > > > > > > Before this patchset, percent limit of callchains didn't checked. > > > Once applied, users can see callchains are disppeared like your case. > > > This is just because 0.5% of the default limit for callchains is too > > > high IMHO - I guess it was originally set for 'fractal' mode which > > > calculates relative percents. So I proposed to change the default in > > > the patch 10/10 but Andi thoughts 0.005% was too small. We need to > > > choose other value like 0.05% ? > > > > Unsure about the limit, but please fold the nice explanation you gave > > about the limits for hist entries and callchains and how the defaults > > are different, and how they can be set at once using --percent-limit. > > Ok, will do. > > > > > Also, would it be overengineering to allow optionally set two limits, > > one for hists and one for callchains? I.e. like: > > > > --percent-limit 1,0.07 > > > > Then: > > > > --percent-limit 0.8 > > > > would be the same as: > > > > --percent-limit 0.8,0.8 > > Originally, the percent limit (threshold) for callchains can be set > using -g/--call-graph option. What Andi asked is to set both limits > using a single option. Not sure it's worth adding another way to > specify the callchain limit. Ok, having that in the docs, i.e. when documenting --percent-limit mention that the callchain limit can be set via the -g option as well will help sort out confusion when trying to set those limits. And have you considered setting these limits dynamicly? I.e. in the TUI? - Arnaldo