From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755839AbcBBROz (ORCPT ); Tue, 2 Feb 2016 12:14:55 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58152 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbcBBROx (ORCPT ); Tue, 2 Feb 2016 12:14:53 -0500 Date: Tue, 2 Feb 2016 09:14:53 -0800 From: Greg KH To: Ksenija =?utf-8?Q?Stanojevi=C4=87?= Cc: Willy Tarreau , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: Move panel driver out of staging Message-ID: <20160202171453.GD26366@kroah.com> References: <1454423901-18030-1-git-send-email-ksenija.stanojevic@gmail.com> <20160202162320.GA25704@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote: > Hi Greg, > > On Tue, Feb 2, 2016 at 5:23 PM, Greg KH wrote: > > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote: > >> Move panel driver from drivers/staging/panel to drivers/misc. > >> > >> Signed-off-by: Ksenija Stanojevic > >> --- > >> drivers/misc/Kconfig | 278 ++++ > >> drivers/misc/Makefile | 1 + > >> drivers/misc/panel.c | 2445 +++++++++++++++++++++++++++++ > >> drivers/staging/Kconfig | 2 - > >> drivers/staging/Makefile | 1 - > >> drivers/staging/panel/Kconfig | 278 ---- > >> drivers/staging/panel/Makefile | 1 - > >> drivers/staging/panel/TODO | 8 - > >> drivers/staging/panel/lcd-panel-cgram.txt | 24 - > >> drivers/staging/panel/panel.c | 2445 ----------------------------- > >> 10 files changed, 2724 insertions(+), 2759 deletions(-) > >> create mode 100644 drivers/misc/panel.c > >> delete mode 100644 drivers/staging/panel/Kconfig > >> delete mode 100644 drivers/staging/panel/Makefile > >> delete mode 100644 drivers/staging/panel/TODO > >> delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt > >> delete mode 100644 drivers/staging/panel/panel.c > > > > > > Can you generate a patch like this with the -M option to git > > format-patch? > > I tried that but it didn't change anything. It worked for me: drivers/misc/Kconfig | 278 ++++++++++++++++++++++++++++++ drivers/misc/Makefile | 1 + drivers/{staging/panel => misc}/panel.c | 0 drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - drivers/staging/panel/Kconfig | 278 ------------------------------ drivers/staging/panel/Makefile | 1 - drivers/staging/panel/TODO | 8 - drivers/staging/panel/lcd-panel-cgram.txt | 24 --- 9 files changed, 279 insertions(+), 314 deletions(-) rename drivers/{staging/panel => misc}/panel.c (100%) delete mode 100644 drivers/staging/panel/Kconfig delete mode 100644 drivers/staging/panel/Makefile delete mode 100644 drivers/staging/panel/TODO delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt See the lines that show the file being renamed? How exactly did you export the patch? > Also, should panel driver have a separate directory in drivers/misc? For a single driver, I wouldn't worry about that, putting it in misc/ is fine. But, you dropped the lcd-panel-cgram.txt file, perhaps you want to keep that somewhere in Documentation/ ? thanks, greg k-h