From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQelv-0000A2-8j for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:29:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQelq-0006go-G8 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:29:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQelq-0006gk-Ao for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:29:42 -0500 Date: Tue, 2 Feb 2016 17:29:39 +0000 From: Stefan Hajnoczi Message-ID: <20160202172939.GE32084@stefanha-x1.localdomain> References: <1454083668-23520-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ytoMbUMiTKPMT3hY" Content-Disposition: inline In-Reply-To: <1454083668-23520-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Alex =?iso-8859-1?Q?Benn=E9e?= --ytoMbUMiTKPMT3hY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 29, 2016 at 04:07:48PM +0000, Stefan Hajnoczi wrote: > The GThread coroutine backend was a portable coroutine implementation. > Over the years all platforms got their own optimized coroutine > implementations and nothing uses the GThread backend anymore. >=20 > In fact, ./configure mentions the GThread backend doesn't work but might > be useful for debugging. Since GDB macros were added to ease debugging > of ucontext coroutines, there seems little point in keeping a broken > backend around. >=20 > Signed-off-by: Stefan Hajnoczi > --- > configure | 19 ++--- > util/coroutine-gthread.c | 198 -----------------------------------------= ------ > 2 files changed, 5 insertions(+), 212 deletions(-) > delete mode 100644 util/coroutine-gthread.c NACK Alex Bennee pointed out that ThreadSanitizer needs the GThread backend because it cannot cope with stack switching. Stefan --ytoMbUMiTKPMT3hY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWsOeDAAoJEJykq7OBq3PInKcH/jRDpvg4JJCKI3YGK6+bw5Ud vnDHUYKdUA1MOu5z0pqLwu7fDnbUzFEFELiCdx7FiClEfejezJWZnGs7WPsuqQLh mgXC1jqBzPstF4soA8/Ls9aOWltJZPhqPUFrJPWFNxG3Jp3wO1nIP1Q3h6lhCtf3 dtrUoAQ/zm8Qe5xoKbY8LrFmkDNJzx0fX68s7hhtymHkJ+AqU5hsomuo2z3L3Rrg XXHepqrKX0zEjoyJg7OeMDy3Sfp9C2p90FbAQG2vrgFb2444ei/qSFDOo9mGo7YV zDYRLOYlg8Z6omdfVytqlvVNucn37N0yO63Gw9HNaEmtE9pqlkASnsL7QIp2Kz8= =QQMu -----END PGP SIGNATURE----- --ytoMbUMiTKPMT3hY--