From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934272AbcBBUuJ (ORCPT ); Tue, 2 Feb 2016 15:50:09 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:50774 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932934AbcBBUuI (ORCPT ); Tue, 2 Feb 2016 15:50:08 -0500 Date: Tue, 2 Feb 2016 21:49:55 +0100 From: Willy Tarreau To: Linus Torvalds Cc: Hannes Frederic Sowa , David Herrmann , "David S. Miller" , netdev , linux-kernel , Eric Dumazet , ???????? ?????????????????? , Tetsuo Handa , Simon McVittie Subject: Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Message-ID: <20160202204955.GD25828@1wt.eu> References: <201601100657.u0A6vk1B025554@mail.home.local> <56B0F574.5080105@stressinduktion.org> <56B11278.8000805@stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 12:44:54PM -0800, Linus Torvalds wrote: > On Tue, Feb 2, 2016 at 12:32 PM, Hannes Frederic Sowa > wrote: > > But "struct pid *" in unix_skb_parms should be enough to get us to > > corresponding "struct cred *" so we can decrement the correct counter during > > skb destruction. > > Umm. I think the "struct cred" may change in between, can't it? You mean for example in case of setuid() or something like this ? willy