From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug Date: Tue, 2 Feb 2016 15:39:12 -0800 Message-ID: <20160202233911.GB19432@atomide.com> References: <20160106182650.GM12777@atomide.com> <568D5F54.7040900@gmail.com> <20160107180700.GN12777@atomide.com> <568EDC8D.7070205@gmail.com> <20160108022619.GS12777@atomide.com> <568F4596.8020206@gmail.com> <20160108075913.GN11364@pali> <569052FE.1040008@gmail.com> <20160121091437.GT7192@pali> <56B077D4.3030902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <56B077D4.3030902@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ivaylo Dimitrov Cc: Nishanth Menon , Paul Walmsley , Aaro Koskinen , Sebastian Reichel , pavel@ucw.cz, Pali =?utf-8?B?Um9ow6Fy?= , linux-omap@vger.kernel.org, Brian Hutchinson , linux-arm-kernel@lists.infradead.org, Roger Quadros List-Id: linux-omap@vger.kernel.org KiBJdmF5bG8gRGltaXRyb3YgPGl2by5nLmRpbWl0cm92Ljc1QGdtYWlsLmNvbT4gWzE2MDIwMiAw MTozNF06Cj4gT24gMjEuMDEuMjAxNiAxMToxNCwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gPk9uIFNh dHVyZGF5IDA5IEphbnVhcnkgMjAxNiAwMjoyMzoyNiBJdmF5bG8gRGltaXRyb3Ygd3JvdGU6Cj4g Pj5UaGUga2V5IHdvcmQgaGVyZSBpcyAic29tZXRpbWVzIi4gaS5lIHNvbWV0aW1lcyBpdCBoYXBl bnMgb24gbm9ybWFsIHJlYm9vdCwKPiA+PnNvbWV0aW1lcyBpdCBoYXBwZW5zIG9uIG9vcHMuCj4g Pgo+ID5TbyB3aGVyZSBpcyBwcm9ibGVtPyBJbiBvbWFwLWdwbWM/IG10ZD8gb25lbmFuZD8gb3Ig dWJpZnM/IE9yIGluCj4gPmRpZmZlcmVudCBjb21wb25lbnQ/IERvIHdlIGtub3cgYXQgbGVhc3Qg dGhpcz8KPiA+Cj4gCj4gSSB0aGluayBJIG1hZGUgc29tZSBwcm9ncmVzcyBvbiB0aGUgaXNzdWUs IGl0IHNlZW1zIEkgaGF2ZSB0byBoYXZlICpib3RoKgo+IGU3YjExZGM3Yjc3YmZjZTBhMzUxMjMw YTVmZWVhZGMxZDBiYmE5OTcKPiAoZTdiMTFkYzdiNzdiZmNlMGEzNTEyMzBhNWZlZWFkYzFkMGJi YTk5NykgcmV2ZXJ0ZWQgKmFuZCoKPiBIV01PRF9JTklUX05PX1JFU0VUIHJlc3RvcmVkIGluIG9t YXAzeHh4X2dwbWNfaHdtb2QgZmxhZ3MgdG8gaGF2ZSB3b3JraW5nCj4gb25lbmFuZC4KClRoYXQg aXMgc3RyYW5nZS4gVGhpcyBpcyB3aGF0IEkgZ2V0IHdpdGggb21hcDJwbHVzX2RlZmNvbmZpZyBh bmQKb21hcC1mb3ItdjQuNS9maXhlcy1yYzEgYWZ0ZXIgZmxhc2hpbmcgdGhlIHJvb3RmcyBhbmQg Ym9vdGluZyBrZXJuZWwKbGlrZSB5b3Ugc3VnZ2VzdGVkIG9uIGlyYzoKCiMgZG1lc2cgfCBncmVw IC1pIC1lIHViaSAtZSBvbmVuYW5kClsgICAgMi41MDI4OTldIG9tYXAyLW9uZW5hbmQgb21hcDIt b25lbmFuZDogaW5pdGlhbGl6aW5nIG9uIENTMCwgcGh5cyBiYXNlIDB4MDEwMDAwMDAsIHZpcnR1 YWwgYmFzZSBkMDk0MDAwMCwgZnJlcSA4MyBNSHoKWyAgICAyLjUxNDM3M10gT25lTkFORCBNYW51 ZmFjdHVyZXI6IE51bW9ueXggKDB4MjApClsgICAgMi41MTkyODddIE11eGVkIE9uZU5BTkQgMjU2 TUIgMS44ViAxNi1iaXQgKDB4NDApClsgICAgMi41MjQ0NDRdIE9uZU5BTkQgdmVyc2lvbiA9IDB4 MDAzMQpbICAgIDIuNjcxOTY2XSA2IG9mcGFydCBwYXJ0aXRpb25zIGZvdW5kIG9uIE1URCBkZXZp Y2Ugb21hcDItb25lbmFuZApbICAgIDIuNjc4NDM2XSBDcmVhdGluZyA2IE1URCBwYXJ0aXRpb25z IG9uICJvbWFwMi1vbmVuYW5kIjoKWyAgICAzLjQxNDc2NF0gdWJpMDogYXR0YWNoaW5nIG10ZDUK WyAgICAzLjY2ODIxMl0gdWJpMDogc2Nhbm5pbmcgaXMgZmluaXNoZWQKWyAgICAzLjcxNjU1Ml0g dWJpMDogYXR0YWNoZWQgbXRkNSAobmFtZSAicm9vdGZzIiwgc2l6ZSAyNTEgTWlCKQpbICAgIDMu NzIyODM5XSB1YmkwOiBQRUIgc2l6ZTogMTMxMDcyIGJ5dGVzICgxMjggS2lCKSwgTEVCIHNpemU6 IDEyOTAyNCBieXRlcwpbICAgIDMuNzMwMTk0XSB1YmkwOiBtaW4uL21heC4gSS9PIHVuaXQgc2l6 ZXM6IDIwNDgvMjA0OCwgc3ViLXBhZ2Ugc2l6ZSA1MTIKWyAgICAzLjczNzMwNF0gdWJpMDogVklE IGhlYWRlciBvZmZzZXQ6IDUxMiAoYWxpZ25lZCA1MTIpLCBkYXRhIG9mZnNldDogMjA0OApbICAg IDMuNzQ0NTM3XSB1YmkwOiBnb29kIFBFQnM6IDIwMTAsIGJhZCBQRUJzOiAwLCBjb3JydXB0ZWQg UEVCczogMApbICAgIDMuNzUxMDM3XSB1YmkwOiB1c2VyIHZvbHVtZTogMSwgaW50ZXJuYWwgdm9s dW1lczogMSwgbWF4LiB2b2x1bWVzIGNvdW50OiAxMjgKWyAgICAzLjc1ODY5N10gdWJpMDogbWF4 L21lYW4gZXJhc2UgY291bnRlcjogMS8wLCBXTCB0aHJlc2hvbGQ6IDQwOTYsIGltYWdlIHNlcXVl bmNlIG51bWJlcjogMApbICAgIDMuNzY3NTc4XSB1YmkwOiBhdmFpbGFibGUgUEVCczogMCwgdG90 YWwgcmVzZXJ2ZWQgUEVCczogMjAxMCwgUEVCcyByZXNlcnZlZCBmb3IgYmFkIFBFQiBoYW5kbGlu ZzogNDAKWyAgICAzLjkyMzk4MF0gdWJpMDogYmFja2dyb3VuZCB0aHJlYWQgInViaV9iZ3QwZCIg c3RhcnRlZCwgUElEIDg1ClsgICAgMy45ODA1MjldIFVCSUZTICh1YmkwOjApOiBiYWNrZ3JvdW5k IHRocmVhZCAidWJpZnNfYmd0MF8wIiBzdGFydGVkLCBQSUQgODcKWyAgICAzLjk5NjMzN10gVUJJ RlMgKHViaTA6MCk6IHJlY292ZXJ5IG5lZWRlZApbICAgIDQuMDc5OTI1XSBVQklGUyAodWJpMDow KTogcmVjb3ZlcnkgY29tcGxldGVkClsgICAgNC4wODU4NzZdIFVCSUZTICh1YmkwOjApOiBVQklG UzogbW91bnRlZCBVQkkgZGV2aWNlIDAsIHZvbHVtZSAwLCBuYW1lICJyb290ZnMiClsgICAgNC4w OTM3ODBdIFVCSUZTICh1YmkwOjApOiBMRUIgc2l6ZTogMTI5MDI0IGJ5dGVzICgxMjYgS2lCKSwg bWluLi9tYXguIEkvTyB1bml0IHNpemVzOiAyMDQ4IGJ5dGVzLzIwNDggYnl0ZXMKWyAgICA0LjEw NDMzOV0gVUJJRlMgKHViaTA6MCk6IEZTIHNpemU6IDI1MjI0MTkyMCBieXRlcyAoMjQwIE1pQiwg MTk1NSBMRUJzKSwgam91cm5hbCBzaXplIDkwMzM3MjggYnl0ZXMgKDggTWlCLCA3MSBMRUJzKQpb ICAgIDQuMTE1NzIyXSBVQklGUyAodWJpMDowKTogcmVzZXJ2ZWQgZm9yIHJvb3Q6IDQxOTA0MzQg Ynl0ZXMgKDQwOTIgS2lCKQpbICAgIDQuMTIyNzcyXSBVQklGUyAodWJpMDowKTogbWVkaWEgZm9y bWF0OiB3NC9yMCAobGF0ZXN0IGlzIHc0L3IwKSwgVVVJRCA4RjMwQTg4QS1GNjA1LTQyOTEtOTky Ny0wMENGM0EyQUUxMTksIHNtYWxsIExQVCBtb2RlbApbICAgIDQuMTM2MDc3XSBWRlM6IE1vdW50 ZWQgcm9vdCAodWJpZnMgZmlsZXN5c3RlbSkgb24gZGV2aWNlIDA6MTUuCgpJIGNvcGllZCBvdmVy IHRoZSBtb2R1bGVzIHRvIHRoaXMgcm9vdGZzIHRvbyA6KSBCdXQgaW4gZ2VuZXJhbCBvbmVuYW5k CnNlZW1zIHRvIGJlaGF2ZSBmb3IgbWUuCgo+IFRvbnksIHNoYWxsIEkgaGFyZGNvZGUgR1BNQ19D U19DT05GSUc0IE9FT05USU1FIHRvIGJlIHRoZSBzYW1lIGFzIE5PTE8ncyBvcgo+IGl0IGRvZXMg bm90IG1ha2Ugc2Vuc2U/CgpOb3Qgc3VyZSB3aGF0IGlzIHN0aWxsIHdyb25nLiBCdXQgeWVhaCBz b21lIGJvcmRlcmxpbmUgR1BNQyB0aW1pbmcKZGlmZmVyZW5jZXMgY291bGQgYWZmZWN0IGl0LgoK UmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 2 Feb 2016 15:39:12 -0800 Subject: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug In-Reply-To: <56B077D4.3030902@gmail.com> References: <20160106182650.GM12777@atomide.com> <568D5F54.7040900@gmail.com> <20160107180700.GN12777@atomide.com> <568EDC8D.7070205@gmail.com> <20160108022619.GS12777@atomide.com> <568F4596.8020206@gmail.com> <20160108075913.GN11364@pali> <569052FE.1040008@gmail.com> <20160121091437.GT7192@pali> <56B077D4.3030902@gmail.com> Message-ID: <20160202233911.GB19432@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Ivaylo Dimitrov [160202 01:34]: > On 21.01.2016 11:14, Pali Roh?r wrote: > >On Saturday 09 January 2016 02:23:26 Ivaylo Dimitrov wrote: > >>The key word here is "sometimes". i.e sometimes it hapens on normal reboot, > >>sometimes it happens on oops. > > > >So where is problem? In omap-gpmc? mtd? onenand? or ubifs? Or in > >different component? Do we know at least this? > > > > I think I made some progress on the issue, it seems I have to have *both* > e7b11dc7b77bfce0a351230a5feeadc1d0bba997 > (e7b11dc7b77bfce0a351230a5feeadc1d0bba997) reverted *and* > HWMOD_INIT_NO_RESET restored in omap3xxx_gpmc_hwmod flags to have working > onenand. That is strange. This is what I get with omap2plus_defconfig and omap-for-v4.5/fixes-rc1 after flashing the rootfs and booting kernel like you suggested on irc: # dmesg | grep -i -e ubi -e onenand [ 2.502899] omap2-onenand omap2-onenand: initializing on CS0, phys base 0x01000000, virtual base d0940000, freq 83 MHz [ 2.514373] OneNAND Manufacturer: Numonyx (0x20) [ 2.519287] Muxed OneNAND 256MB 1.8V 16-bit (0x40) [ 2.524444] OneNAND version = 0x0031 [ 2.671966] 6 ofpart partitions found on MTD device omap2-onenand [ 2.678436] Creating 6 MTD partitions on "omap2-onenand": [ 3.414764] ubi0: attaching mtd5 [ 3.668212] ubi0: scanning is finished [ 3.716552] ubi0: attached mtd5 (name "rootfs", size 251 MiB) [ 3.722839] ubi0: PEB size: 131072 bytes (128 KiB), LEB size: 129024 bytes [ 3.730194] ubi0: min./max. I/O unit sizes: 2048/2048, sub-page size 512 [ 3.737304] ubi0: VID header offset: 512 (aligned 512), data offset: 2048 [ 3.744537] ubi0: good PEBs: 2010, bad PEBs: 0, corrupted PEBs: 0 [ 3.751037] ubi0: user volume: 1, internal volumes: 1, max. volumes count: 128 [ 3.758697] ubi0: max/mean erase counter: 1/0, WL threshold: 4096, image sequence number: 0 [ 3.767578] ubi0: available PEBs: 0, total reserved PEBs: 2010, PEBs reserved for bad PEB handling: 40 [ 3.923980] ubi0: background thread "ubi_bgt0d" started, PID 85 [ 3.980529] UBIFS (ubi0:0): background thread "ubifs_bgt0_0" started, PID 87 [ 3.996337] UBIFS (ubi0:0): recovery needed [ 4.079925] UBIFS (ubi0:0): recovery completed [ 4.085876] UBIFS (ubi0:0): UBIFS: mounted UBI device 0, volume 0, name "rootfs" [ 4.093780] UBIFS (ubi0:0): LEB size: 129024 bytes (126 KiB), min./max. I/O unit sizes: 2048 bytes/2048 bytes [ 4.104339] UBIFS (ubi0:0): FS size: 252241920 bytes (240 MiB, 1955 LEBs), journal size 9033728 bytes (8 MiB, 71 LEBs) [ 4.115722] UBIFS (ubi0:0): reserved for root: 4190434 bytes (4092 KiB) [ 4.122772] UBIFS (ubi0:0): media format: w4/r0 (latest is w4/r0), UUID 8F30A88A-F605-4291-9927-00CF3A2AE119, small LPT model [ 4.136077] VFS: Mounted root (ubifs filesystem) on device 0:15. I copied over the modules to this rootfs too :) But in general onenand seems to behave for me. > Tony, shall I hardcode GPMC_CS_CONFIG4 OEONTIME to be the same as NOLO's or > it does not make sense? Not sure what is still wrong. But yeah some borderline GPMC timing differences could affect it. Regards, Tony