From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbcBCKxP (ORCPT ); Wed, 3 Feb 2016 05:53:15 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35579 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbcBCKxM (ORCPT ); Wed, 3 Feb 2016 05:53:12 -0500 Date: Wed, 3 Feb 2016 11:53:07 +0100 From: Ingo Molnar To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Clemens Ladisch , Jonathan Corbet , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Arnd Bergmann , Greg Kroah-Hartman , linux-doc@vger.kernel.org Subject: Re: [PATCH] hpet: drop stale link Message-ID: <20160203105307.GA21926@gmail.com> References: <1454326374-7317-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454326374-7317-1-git-send-email-mst@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Michael S. Tsirkin wrote: > Looks like the HPET spec at intel.com got moved. > It isn't hard to find so drop the link, just mention > the revision assumed. > > Suggested-by: Thomas Gleixner > Signed-off-by: Michael S. Tsirkin > --- > drivers/char/hpet.c | 2 +- > Documentation/timers/hpet.txt | 2 +- > arch/x86/Kconfig | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c > index 240b6cf..86c5f4d 100644 > --- a/drivers/char/hpet.c > +++ b/drivers/char/hpet.c > @@ -42,7 +42,7 @@ > /* > * The High Precision Event Timer driver. > * This driver is closely modelled after the rtc.c driver. > - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf > + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf > */ > #define HPET_USER_FREQ (64) > #define HPET_DRIFT (500) > diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt > index 767392f..f24e978 100644 > --- a/Documentation/timers/hpet.txt > +++ b/Documentation/timers/hpet.txt > @@ -3,7 +3,7 @@ > The High Precision Event Timer (HPET) hardware follows a specification > by Intel and Microsoft which can be found at > > - http://www.intel.com/hardwaredesign/hpetspec_1.pdf > +http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf > > Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision") > and up to 32 comparators. Normally three or more comparators are provided, > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 9af2e63..f32faba 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -778,7 +778,7 @@ config HPET_TIMER > The HPET provides a stable time base on SMP > systems, unlike the TSC, but it is more expensive to access, > as it is off-chip. You can find the HPET spec at > - . > + . > > You can safely choose Y here. However, HPET will only be > activated if the platform and the BIOS support this feature. In fact we can also remove the link from this Kconfig entry, as it's highly unlikely that a user doing kernel configuration would want to start reading a spec. Thanks, Ingo