Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

[Dan Carpenter]

On Tue, Feb 02, 2016 at 06:57:46AM +0530, Bijosh Thykkoottathil wrote:
> Gentle reminder.

Wait for two more weeks before reminding us.

regards,
dan carpenter

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

[Greg KH]

On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote:
> Fixes following coding style issues reported by the check patch script.
>     - ERROR: Macros with complex values should be enclosed in parentheses
> 
>     Moving static storage class to the beginning of declaration fixes these
>     errors.

Well that's a horrid fix for this, as you aren't doing anything
different here.

Fix the tool if it is reporting things incorrectly, don't blindly change
code for no reason please.  checkpatch isn't always correct, as you have
found out.

thanks,

greg k-h

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

[Sudip Mukherjee]

On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.t@hotmail.com>

You do not need this From: line here. The email From: header is
sufficient.

> 
> Fixes following coading style issues reported by the check patch script.
>     - ERROR: Macros with complex values should be enclosed in parentheses
>     - CHECK: struct mutex definition without comment
>     - CHECK: spinlock_t definition without comment
>     - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code
>       rather than BUG() or BUG_ON()
>     - WARNING: storage class should be at the beginning of the declaration

You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.

regards
sudip