All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Clemens Ladisch <clemens@ladisch.de>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] hpet: drop stale link
Date: Wed, 3 Feb 2016 13:54:32 +0200	[thread overview]
Message-ID: <20160203135349-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20160203105307.GA21926@gmail.com>

On Wed, Feb 03, 2016 at 11:53:07AM +0100, Ingo Molnar wrote:
> 
> * Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> > Looks like the HPET spec at intel.com got moved.
> > It isn't hard to find so drop the link, just mention
> > the revision assumed.
> > 
> > Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  drivers/char/hpet.c           | 2 +-
> >  Documentation/timers/hpet.txt | 2 +-
> >  arch/x86/Kconfig              | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> > index 240b6cf..86c5f4d 100644
> > --- a/drivers/char/hpet.c
> > +++ b/drivers/char/hpet.c
> > @@ -42,7 +42,7 @@
> >  /*
> >   * The High Precision Event Timer driver.
> >   * This driver is closely modelled after the rtc.c driver.
> > - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> > + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> >   */
> >  #define	HPET_USER_FREQ	(64)
> >  #define	HPET_DRIFT	(500)
> > diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
> > index 767392f..f24e978 100644
> > --- a/Documentation/timers/hpet.txt
> > +++ b/Documentation/timers/hpet.txt
> > @@ -3,7 +3,7 @@
> >  The High Precision Event Timer (HPET) hardware follows a specification
> >  by Intel and Microsoft which can be found at
> >  
> > -	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> > +http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> >  
> >  Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
> >  and up to 32 comparators.  Normally three or more comparators are provided,
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 9af2e63..f32faba 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -778,7 +778,7 @@ config HPET_TIMER
> >  	  The HPET provides a stable time base on SMP
> >  	  systems, unlike the TSC, but it is more expensive to access,
> >  	  as it is off-chip.  You can find the HPET spec at
> > -	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
> > +	  <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
> >  
> >  	  You can safely choose Y here.  However, HPET will only be
> >  	  activated if the platform and the BIOS support this feature.
> 
> In fact we can also remove the link from this Kconfig entry, as it's highly 
> unlikely that a user doing kernel configuration would want to start reading a 
> spec.
> 
> Thanks,
> 
> 	Ingo

Hmm looks like the patch does not match the description.
Maybe I forgot to commit, or something.
Sorry - will repost.

  reply	other threads:[~2016-02-03 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 11:32 [PATCH] hpet: drop stale link Michael S. Tsirkin
2016-02-03 10:53 ` Ingo Molnar
2016-02-03 11:54   ` Michael S. Tsirkin [this message]
2016-02-10 20:14 ` Jonathan Corbet
2016-02-10 23:08   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160203135349-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=arnd@arndb.de \
    --cc=clemens@ladisch.de \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.