From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755785AbcBCOGH (ORCPT ); Wed, 3 Feb 2016 09:06:07 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35751 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbcBCOGE (ORCPT ); Wed, 3 Feb 2016 09:06:04 -0500 Date: Wed, 3 Feb 2016 19:36:00 +0530 From: Viresh Kumar To: rjw@rjwysocki.net, Gautham R Shenoy Cc: Shilpasri G Bhat , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, pc@us.ibm.com, anton@samba.org, shreyas@linux.vnet.ibm.com, bsingharora@gmail.com, mpe@ellerman.id.au, linux-api@vger.kernel.org Subject: Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Message-ID: <20160203140600.GG3469@vireshk> References: <1454442102-1229-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1454442102-1229-7-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <20160203082700.GZ31828@vireshk> <56B1BD71.2050403@linux.vnet.ibm.com> <20160203090357.GA31828@vireshk> <20160203120258.GA32294@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160203120258.GA32294@in.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-02-16, 17:32, Gautham R Shenoy wrote: > Regarding the table-format, it breaks the sysfs's one-value-per-file > rule. So I would still prefer each throttle reason being a separate > file which gives the number of times the chip frequency was throttled > due to that reason. We can live without the per-frequency > throttle stats listed in the throttle_status. > > So, would the following be sysfs group structure be acceptable? > > $ls -1 /sys/devices/system/cpu/cpuX/cpufreq/throttle_stats/ > unthrottle > powercap > overtemp > supply_fault > overcurrent > occ_reset > turbo_stat > sub_turbo_stat That was suggested for your convenience only, feel free to keep it the way you want it. I forgot about the one-value-per-file thing really, but we are using that for cpufreq-stats as well. And now that you have mentioned that to me, why shouldn't this stats directory be moved to debugfs ? :) We are never going to perform a store here, isn't it ? And is just for information, nothing more. @Rafael: ?? -- viresh