From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933137AbcBCQYm (ORCPT ); Wed, 3 Feb 2016 11:24:42 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:56508 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757790AbcBCQYQ (ORCPT ); Wed, 3 Feb 2016 11:24:16 -0500 Date: Wed, 3 Feb 2016 11:24:00 -0500 From: Johannes Weiner To: Sergey Senozhatsky Cc: Andrew Morton , Vladimir Davydov , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] mm/workingset: do not forget to unlock page Message-ID: <20160203162400.GB10440@cmpxchg.org> References: <1454493513-19316-1-git-send-email-sergey.senozhatsky@gmail.com> <20160203104136.GA517@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160203104136.GA517@swordfish> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2016 at 07:41:36PM +0900, Sergey Senozhatsky wrote: > From 1d6315221f2f81c53c99f9980158f8ae49dbd582 Mon Sep 17 00:00:00 2001 > From: Sergey Senozhatsky > Date: Wed, 3 Feb 2016 18:49:16 +0900 > Subject: [PATCH] mm/workingset: do not forget to unlock_page in workingset_activation > > Do not return from workingset_activation() with locked rcu and page. > > Signed-off-by: Sergey Senozhatsky Thanks Sergey. Even though I wrote this function, my brain must have gone "it can't be locking anything when it returns NULL, right?" It's a dumb interface. Luckily, that's fixed with follow-up patches in -mm. As for this one: Acked-by: Johannes Weiner Fixes: mm: workingset: per-cgroup cache thrash detection Andrew, can you please fold this? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] mm/workingset: do not forget to unlock page Date: Wed, 3 Feb 2016 11:24:00 -0500 Message-ID: <20160203162400.GB10440@cmpxchg.org> References: <1454493513-19316-1-git-send-email-sergey.senozhatsky@gmail.com> <20160203104136.GA517@swordfish> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20160203104136.GA517@swordfish> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergey Senozhatsky Cc: Andrew Morton , Vladimir Davydov , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky On Wed, Feb 03, 2016 at 07:41:36PM +0900, Sergey Senozhatsky wrote: > From 1d6315221f2f81c53c99f9980158f8ae49dbd582 Mon Sep 17 00:00:00 2001 > From: Sergey Senozhatsky > Date: Wed, 3 Feb 2016 18:49:16 +0900 > Subject: [PATCH] mm/workingset: do not forget to unlock_page in workingset_activation > > Do not return from workingset_activation() with locked rcu and page. > > Signed-off-by: Sergey Senozhatsky Thanks Sergey. Even though I wrote this function, my brain must have gone "it can't be locking anything when it returns NULL, right?" It's a dumb interface. Luckily, that's fixed with follow-up patches in -mm. As for this one: Acked-by: Johannes Weiner Fixes: mm: workingset: per-cgroup cache thrash detection Andrew, can you please fold this? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org