From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965733AbcBCTct (ORCPT ); Wed, 3 Feb 2016 14:32:49 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26462 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965248AbcBCTcq (ORCPT ); Wed, 3 Feb 2016 14:32:46 -0500 Date: Wed, 3 Feb 2016 11:32:33 -0800 From: "Darrick J. Wong" To: Joe Perches Cc: Huaitong Han , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: add a line break for proc mb_groups display Message-ID: <20160203193233.GB5842@birch.djwong.org> References: <1454505546-4875-1-git-send-email-huaitong.han@intel.com> <20160203181356.GA5842@birch.djwong.org> <1454524232.7291.105.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454524232.7291.105.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > This patch adds a line break for proc mb_groups display. > > Using 2 lines for output might break any existing users. > > Are there any? It's a multiline file if you have more than one blockgroup; this just makes it so that you don't have to special-case BG 0. IOW: mb_groups scripts already had to parse multiple lines, and most likely any script parsing it would inject a newline after the header. --D > > > > > > > Signed-off-by: Huaitong Han > > > --- > > >  fs/ext4/mballoc.c | 2 +- > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > > > index 61eaf74..4424b7b 100644 > > > --- a/fs/ext4/mballoc.c > > > +++ b/fs/ext4/mballoc.c > > > @@ -2285,7 +2285,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v) > > >   if (group == 0) > > >   seq_puts(seq, "#group: free  frags first [" > > >         " 2^0   2^1   2^2   2^3   2^4   2^5   2^6  " > > > -       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]"); > > > +       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]\n"); > > > > Oh, heh. > > > > Reviewed-by: Darrick J. Wong > > > > --D > > > > >   > > >   i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) + > > >   sizeof(struct ext4_group_info); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html