From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v7 16/18] tools/libxl: store remus_ops in checkpoint device state Date: Wed, 3 Feb 2016 19:40:59 +0000 Message-ID: <20160203194059.GE23178@citrix.com> References: <1454045254-3711-1-git-send-email-wency@cn.fujitsu.com> <1454045254-3711-17-git-send-email-wency@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1454045254-3711-17-git-send-email-wency@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wen Congyang Cc: Lars Kurth , Changlong Xie , Wei Liu , Ian Campbell , Andrew Cooper , Jiang Yunhong , Ian Jackson , xen devel , Dong Eddie , Gui Jianfeng , Shriram Rajagopalan , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Fri, Jan 29, 2016 at 01:27:32PM +0800, Wen Congyang wrote: > Checkpoint device is an abstract layer to do checkpoint. > COLO can also use it to do checkpoint. But there are > still some codes in checkpoint device which touch remus. > > This patch and: > tools/libxl: move remus state into a seperate structure > tools/libxl: seperate device init/cleanup from checkpoint device layer > will seperate remus from checkpoint device layer. > > We use remus ops directly in checkpoint device. Store it > in checkpoint device state so that we do not aware of > remus_ops in the checkpoint device layer. > > It is pure refactoring and no functional changes. > > Signed-off-by: Wen Congyang > Signed-off-by: Yang Hongyang > Acked-by:Ian Campbell > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu