All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] python-cffi: add host variant
Date: Wed, 3 Feb 2016 23:00:10 +0100	[thread overview]
Message-ID: <20160203230010.0112a74e@free-electrons.com> (raw)
In-Reply-To: <1451978244-15878-4-git-send-email-yegorslists@googlemail.com>

Hello,

On Tue,  5 Jan 2016 08:17:24 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Host variant is needed to cross-compile CFFI based C library wrappers.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes:
> 	v2: add host-libffi dependency
> 
>  package/python-cffi/python-cffi.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/python-cffi/python-cffi.mk b/package/python-cffi/python-cffi.mk
> index 70fbe02..02c969b 100644
> --- a/package/python-cffi/python-cffi.mk
> +++ b/package/python-cffi/python-cffi.mk
> @@ -11,5 +11,7 @@ PYTHON_CFFI_SETUP_TYPE = setuptools
>  PYTHON_CFFI_DEPENDENCIES = host-pkgconf libffi
>  PYTHON_CFFI_LICENSE = MIT
>  PYTHON_CFFI_LICENSE_FILES = LICENSE
> +HOST_PYTHON_CFFI_DEPENDENCIES = host-python-pycparser host-libffi
>  
>  $(eval $(python-package))
> +$(eval $(host-python-package))

This wasn't building properly here, because python-cffi uses pkg-config
to get the flags to link with libffi, and by default our pkg-config
returns results that are valid to build stuff for the target, not for
the host.

So, I've fixed that by passing a bunch of pkg-config environment
variables when building the host package.

Also, you were missing the host-pkgconf dependency for the dependencies
of host variant.

Committed with those issues fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-02-03 22:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  7:17 [Buildroot] [PATCH v2 0/3] CFFI backend yegorslists at googlemail.com
2016-01-05  7:17 ` [Buildroot] [PATCH v2 1/3] libffi: fix headers location for host-libffi yegorslists at googlemail.com
2016-02-03 21:54   ` Thomas Petazzoni
2016-01-05  7:17 ` [Buildroot] [PATCH v2 2/3] python-pycparser: new package yegorslists at googlemail.com
2016-02-03 21:54   ` Thomas Petazzoni
2016-01-05  7:17 ` [Buildroot] [PATCH v2 3/3] python-cffi: add host variant yegorslists at googlemail.com
2016-01-05 15:40   ` Yegor Yefremov
2016-01-05 15:45     ` Yegor Yefremov
2016-02-03 22:00   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160203230010.0112a74e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.