From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757579AbcBDNUC (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 08:20:02 -0500
Received: from smtprelay0135.hostedemail.com ([216.40.44.135]:54995 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1750748AbcBDNUA convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 08:20:00 -0500
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:152:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1513:1515:1516:1518:1521:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2827:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3870:3871:3873:4250:5007:6119:6261:7576:7875:8957:10004:10400:10848:10967:11026:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13311:13357:14659:21060:21080:21222:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: shock88_915ec714b162c
X-Filterd-Recvd-Size: 1864
Date: Thu, 4 Feb 2016 08:19:57 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: =?UTF-8?B?5bmz5p2+6ZuF5bez?= /
	 =?UTF-8?B?SElSQU1BVFXvvIxNQVNBTUk=?= 
	<masami.hiramatsu.pt@hitachi.com>
Cc: "'Martin KaFai Lau'" <kafai@fb.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Josef Bacik <jbacik@fb.com>, Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH RESEND] kprobe: Use percpu counter to collect nhit
 statistics
Message-ID: <20160204081957.3c31f719@gandalf.local.home>
In-Reply-To: <50399556C9727B4D88A595C8584AAB37B4DDA257@GSjpTKYDCembx31.service.hitachi.net>
References: <1454531308-2441898-1-git-send-email-kafai@fb.com>
	<50399556C9727B4D88A595C8584AAB37B4DDA257@GSjpTKYDCembx31.service.hitachi.net>
X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 4 Feb 2016 10:24:12 +0000
平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> wrote:

> From: Martin KaFai Lau [mailto:kafai@fb.com]
> >
> >When doing ebpf+kprobe on some hot TCP functions (e.g.
> >tcp_rcv_established), the kprobe_dispatcher shows up in 'perf report'.
> >
> >In kprobe_dispatcher(), there is a lot of cache bouncing
> >in 'tk->nhit++'.  'tk->nhit' and 'tk->tp.flags' also share
> >the same cacheline.
> >  
> 
> Ingo, could you consider to merge this?
> 

Ingo, you can also add my

 Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve