From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758105AbcBDNvL (ORCPT ); Thu, 4 Feb 2016 08:51:11 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:57854 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908AbcBDNvI (ORCPT ); Thu, 4 Feb 2016 08:51:08 -0500 Date: Thu, 4 Feb 2016 13:50:56 +0000 From: Russell King - ARM Linux To: Benjamin LaHaise Cc: Stephen Rothwell , Geert Uytterhoeven , Linux-Next , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: linux-next: build failure after merge of the aio tree Message-ID: <20160204135056.GE10826@n2100.arm.linux.org.uk> References: <20160112164034.0fe945a7@canb.auug.org.au> <20160112163835.GD347@kvack.org> <20160127134024.0fababf6@canb.auug.org.au> <20160129113056.GP10826@n2100.arm.linux.org.uk> <20160204131959.6695c7bf@canb.auug.org.au> <20160204134142.GA16315@kvack.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160204134142.GA16315@kvack.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 08:41:42AM -0500, Benjamin LaHaise wrote: > On Thu, Feb 04, 2016 at 01:19:59PM +1100, Stephen Rothwell wrote: > > Hi Benjamin, > > > > On Fri, 29 Jan 2016 13:03:39 +0100 Geert Uytterhoeven wrote: > > > > > > On Fri, Jan 29, 2016 at 12:30 PM, Russell King - ARM Linux > > > wrote: > > > >> Background: new aio code is adding __get_user() calls referencing 64 > > > >> bit quantities (__u64 and __s64). > > > > > > > > There's lots more architectures which do not support 64-bit get_user() > > > > _or_ __get_user(): avr32, blackfin, metag for example, and m68k which > > > > has this interesting thing "/* case 8: disabled because gcc-4.1 has a > > > > broken typeof \" in its *get_user() implementation. > > > > > > And if you enable it again, you get lots of "warning: cast to pointer from > > > integer of different size", like you mentioned. > > > > Any thoughts? I am still using the version of tha aio tree from > > next-20160111. > > I am still convinced that this is an architecture issue. Given that 64 bit > values work in the *get_user implementations on other architectures, I see > no reason there should need to be a workaround for this in common code. So you're happy to break x86-32 then... -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: linux-next: build failure after merge of the aio tree Date: Thu, 4 Feb 2016 13:50:56 +0000 Message-ID: <20160204135056.GE10826@n2100.arm.linux.org.uk> References: <20160112164034.0fe945a7@canb.auug.org.au> <20160112163835.GD347@kvack.org> <20160127134024.0fababf6@canb.auug.org.au> <20160129113056.GP10826@n2100.arm.linux.org.uk> <20160204131959.6695c7bf@canb.auug.org.au> <20160204134142.GA16315@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160204134142.GA16315@kvack.org> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin LaHaise Cc: Stephen Rothwell , Geert Uytterhoeven , Linux-Next , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-next.vger.kernel.org On Thu, Feb 04, 2016 at 08:41:42AM -0500, Benjamin LaHaise wrote: > On Thu, Feb 04, 2016 at 01:19:59PM +1100, Stephen Rothwell wrote: > > Hi Benjamin, > > > > On Fri, 29 Jan 2016 13:03:39 +0100 Geert Uytterhoeven wrote: > > > > > > On Fri, Jan 29, 2016 at 12:30 PM, Russell King - ARM Linux > > > wrote: > > > >> Background: new aio code is adding __get_user() calls referencing 64 > > > >> bit quantities (__u64 and __s64). > > > > > > > > There's lots more architectures which do not support 64-bit get_user() > > > > _or_ __get_user(): avr32, blackfin, metag for example, and m68k which > > > > has this interesting thing "/* case 8: disabled because gcc-4.1 has a > > > > broken typeof \" in its *get_user() implementation. > > > > > > And if you enable it again, you get lots of "warning: cast to pointer from > > > integer of different size", like you mentioned. > > > > Any thoughts? I am still using the version of tha aio tree from > > next-20160111. > > I am still convinced that this is an architecture issue. Given that 64 bit > values work in the *get_user implementations on other architectures, I see > no reason there should need to be a workaround for this in common code. So you're happy to break x86-32 then... -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 4 Feb 2016 13:50:56 +0000 Subject: linux-next: build failure after merge of the aio tree In-Reply-To: <20160204134142.GA16315@kvack.org> References: <20160112164034.0fe945a7@canb.auug.org.au> <20160112163835.GD347@kvack.org> <20160127134024.0fababf6@canb.auug.org.au> <20160129113056.GP10826@n2100.arm.linux.org.uk> <20160204131959.6695c7bf@canb.auug.org.au> <20160204134142.GA16315@kvack.org> Message-ID: <20160204135056.GE10826@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Feb 04, 2016 at 08:41:42AM -0500, Benjamin LaHaise wrote: > On Thu, Feb 04, 2016 at 01:19:59PM +1100, Stephen Rothwell wrote: > > Hi Benjamin, > > > > On Fri, 29 Jan 2016 13:03:39 +0100 Geert Uytterhoeven wrote: > > > > > > On Fri, Jan 29, 2016 at 12:30 PM, Russell King - ARM Linux > > > wrote: > > > >> Background: new aio code is adding __get_user() calls referencing 64 > > > >> bit quantities (__u64 and __s64). > > > > > > > > There's lots more architectures which do not support 64-bit get_user() > > > > _or_ __get_user(): avr32, blackfin, metag for example, and m68k which > > > > has this interesting thing "/* case 8: disabled because gcc-4.1 has a > > > > broken typeof \" in its *get_user() implementation. > > > > > > And if you enable it again, you get lots of "warning: cast to pointer from > > > integer of different size", like you mentioned. > > > > Any thoughts? I am still using the version of tha aio tree from > > next-20160111. > > I am still convinced that this is an architecture issue. Given that 64 bit > values work in the *get_user implementations on other architectures, I see > no reason there should need to be a workaround for this in common code. So you're happy to break x86-32 then... -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.