From: Ingo Molnar <mingo@kernel.org>
To: Tom Herbert <tom@herbertland.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Peter Anvin <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
kernel-team <kernel-team@fb.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64
Date: Fri, 5 Feb 2016 09:01:36 +0100 [thread overview]
Message-ID: <20160205080136.GA31671@gmail.com> (raw)
In-Reply-To: <CALx6S37+F9UnyDuOgXHKqhNQvBXoQe8G2GCWPbhZE8QBdmz3vg@mail.gmail.com>
* Tom Herbert <tom@herbertland.com> wrote:
> [....] gcc turns these switch statements into jump tables (not function tables
> which is what Ingo's example code was using). [...]
So to the extent this still matters, on most x86 microarchitectures that count,
jump tables and function call tables (i.e. virtual functions that C++ uses) are
generally optimized by the same branch predictor hardware mechanism. Indirect
jumps (jump tables) and indirect calls (function pointer tables) are very similar
conceptually. That is why posted the indirect calls test code.
( The only branching variant that will perform badly even on the latest uarchs are
indirect returns: to modify the return address on the stack. )
So my narrow performance point stands, if any sort of indirect jump is used. They
should be avoided if possible, because it's pretty hard for the hardware to get it
right.
As Linus noticed, data lookup tables are the intelligent solution: if you manage
to offload the logic into arithmetics and not affect the control flow then that's
a big win. The inherent branching will be hidden by executing on massively
parallel arithmetics units which effectively execute everything fed to them in a
single cycle.
In any case, when submitting such patches, please get into the habit of looking at
and posting perf stat output - it will give us a good idea about the quality of an
implementation.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-05 8:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 19:18 [PATCH v3 net-next] net: Implement fast csum_partial for x86_64 Tom Herbert
2016-02-04 9:30 ` Ingo Molnar
2016-02-04 10:56 ` Ingo Molnar
2016-02-04 19:24 ` Tom Herbert
2016-02-05 9:24 ` Ingo Molnar
2016-02-04 21:46 ` Linus Torvalds
2016-02-04 22:09 ` Linus Torvalds
2016-02-05 1:27 ` Linus Torvalds
2016-02-05 1:39 ` Linus Torvalds
2016-02-04 22:43 ` Tom Herbert
2016-02-04 22:57 ` Linus Torvalds
2016-02-05 8:01 ` Ingo Molnar [this message]
2016-02-05 10:07 ` David Laight
2016-02-04 11:08 ` David Laight
2016-02-04 16:51 ` Alexander Duyck
2016-02-04 16:58 ` Tom Herbert
2016-02-04 17:09 ` David Laight
2016-02-04 20:59 ` Tom Herbert
2016-02-04 21:09 ` Alexander Duyck
2016-02-04 19:22 ` Alexander Duyck
2016-02-04 19:31 ` Tom Herbert
2016-02-04 19:44 ` Tom Herbert
2016-02-04 20:03 ` Alexander Duyck
2016-02-08 20:12 George Spelvin
2016-02-09 10:48 ` David Laight
2016-02-10 0:53 ` George Spelvin
2016-02-10 11:39 ` David Laight
2016-02-10 14:43 ` George Spelvin
2016-02-10 15:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205080136.GA31671@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tom@herbertland.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.