From: Kevin Wern <kevin.m.wern@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] checkpatch.pl: fix naked sscanf false positives
Date: Fri, 05 Feb 2016 08:29:52 +0000 [thread overview]
Message-ID: <20160205082952.GA18361@kwern-VirtualBox> (raw)
There is a section of checkpatch.pl that intends to ensure the return
value of sscanf is always checked. However, in certain cases, like in
drivers/staging/dgnc/dgnc.mod.c, the symbol for sscanf is used without
calling the function:
static const struct modversion_info ____versions[]
__used
__attribute__((section("__versions"))) = {
...
{ 0x20c55ae0, __VMLINUX_SYMBOL_STR(sscanf) },
...
};
This currently results in a warning, which is undesirable. We should
adjust the script's first regex condition to match *calls* to sscanf,
not just the symbol itself.
Signed-off-by: Kevin Wern <kevin.m.wern@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 0147c91..199247d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5452,7 +5452,7 @@ sub process {
# check for naked sscanf
if ($^V && $^V ge 5.10.0 &&
defined $stat &&
- $line =~ /\bsscanf\b/ &&
+ $line =~ /\bsscanf\b\s*$balanced_parens/ &&
($stat !~ /$Ident\s*=\s*sscanf\s*$balanced_parens/ &&
$stat !~ /\bsscanf\s*$balanced_parens\s*(?:$Compare)/ &&
$stat !~ /(?:$Compare)\s*\bsscanf\s*$balanced_parens/)) {
--
1.9.1
next reply other threads:[~2016-02-05 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 8:29 Kevin Wern [this message]
2016-02-05 9:46 ` [PATCH] checkpatch.pl: fix naked sscanf false positives Dan Carpenter
2016-02-06 5:26 ` Joe Perches
2016-02-06 6:58 ` Kevin Wern
2016-02-06 17:20 ` Joe Perches
2016-02-06 21:24 ` Kevin Wern
2016-02-06 23:08 ` Joe Perches
2016-02-12 5:35 ` Kevin Wern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205082952.GA18361@kwern-VirtualBox \
--to=kevin.m.wern@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.