From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbcBEMmq (ORCPT ); Fri, 5 Feb 2016 07:42:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37493 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcBEMmc (ORCPT ); Fri, 5 Feb 2016 07:42:32 -0500 Date: Fri, 5 Feb 2016 10:42:30 -0200 From: Arnaldo Carvalho de Melo To: Marcin =?utf-8?Q?=C5=9Alusarz?= Cc: LKML , Namhyung Kim Subject: Re: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps Message-ID: <20160205124230.GA15395@redhat.com> References: <20160101030321.GA2217@marcin-Inspiron-7720> <20160104012528.GA5950@danjae.kornet> <20160107231600.GA21372@marcin-Inspiron-7720> <20160109094205.GA7818@danjae.kornet> <20160119190303.GA17579@marcin-Inspiron-7720> <20160204223925.GA19157@marcin-Inspiron-7720> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160204223925.GA19157@marcin-Inspiron-7720> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Feb 04, 2016 at 11:39:25PM +0100, Marcin Ślusarz escreveu: > On Tue, Jan 19, 2016 at 08:03:03PM +0100, Marcin Ślusarz wrote: > > Steam frequently puts game binaries in folders with spaces. > > > > Note: "(deleted)" markers are now treated as part of the file name. > > > > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c > > ("perf tools: Use sscanf for parsing /proc/pid/maps"). > > > > Signed-off-by: Marcin Ślusarz > > Acked-by: Namhyung Kim > > Cc: Arnaldo Carvalho de Melo > > Gentle ping ;) Thanks for being gentle, appreciated ;-) Applied to perf/core, - Arnaldo > > --- > > tools/perf/util/event.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c > > index 8b10621..956187b 100644 > > --- a/tools/perf/util/event.c > > +++ b/tools/perf/util/event.c > > @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool, > > strcpy(execname, ""); > > > > /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */ > > - n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n", > > + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n", > > &event->mmap2.start, &event->mmap2.len, prot, > > &event->mmap2.pgoff, &event->mmap2.maj, > > &event->mmap2.min, > > -- > > 2.1.4 > >