From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Date: Fri, 5 Feb 2016 15:58:31 +0100 Message-ID: <20160205145831.GA14084@wunner.de> References: <9BD218709B5F2A4F96F08B4A3B98A897372F1356@SHSMSX104.ccr.corp.intel.com> <20160205002710.GA13964@wunner.de> <20160205110927.GG7134@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.hostsharing.net (mailout3.hostsharing.net [176.9.242.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38CC36E1BC for ; Fri, 5 Feb 2016 06:58:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160205110927.GG7134@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , "Li, Weinan Z" , "gustav.fagerlind@gmail.com" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org SGkgQ2hyaXMsCgpPbiBGcmksIEZlYiAwNSwgMjAxNiBhdCAxMTowOToyN0FNICswMDAwLCBDaHJp cyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBGZWIgMDUsIDIwMTYgYXQgMDE6Mjc6MTBBTSArMDEw MCwgTHVrYXMgV3VubmVyIHdyb3RlOgo+ID4gT24gVGh1LCBGZWIgMDQsIDIwMTYgYXQgMDk6MjE6 MTdBTSArMDAwMCwgTGksIFdlaW5hbiBaIHdyb3RlOgo+ID4gPiBXZSBzdGlsbCBuZWVkIHRoaXMg cGF0Y2guIFNlZW1zIDU0NjMyYWJlOGNhMyAoImRybS9pOTE1OiBGaXggb29wcyBjYXVzZWQgYnkg ZmJkZXYgaW5pdGlhbGl6YXRpb24KPiA+ID4gZmFpbHVyZSIpIGFzIHdlbGwgYXMgMzY2ZTM5YjRk MmM1ICgiZHJtL2k5MTU6IFRlYXIgZG93biBmYmRldiBpZgo+ID4gPiBpbml0aWFsaXphdGlvbiBm YWlscyIpIHRoaXMgMiBwYXRjaGVzIGNhbj8/P3QgY292ZXIgdGhpcyBjYXNlLiBJdD8/P3MgYWNj ZXNzIGlmYmRldi0+ZmIgYmVmb3JlIHRoZSBpbml0aWFsaXphdGlvbgo+ID4gPiBmaW5pc2hlZCwg YnV0IG5vdCBpbml0aWFsaXphdGlvbiBmYWlsZWQuIElmIGRvbj8/P3QgaGF2ZSBhbnkgb3RoZXIg cGF0Y2hlcyBvciBjb2RlIHVwZGF0ZSByZWxhdGl2ZSwgaXQgbWF5IHN0aWxsIGhhdmUgaW4gNC41 Lgo+ID4gCj4gPiBPa2F5LCBJIHNlZS4KPiA+IAo+ID4gPiAKPiA+ID4gYWRkIGluZm8gTlVMTCBj aGVjayBzaG91bGQgYmUgYmV0dGVyLCBpdCBpcyBhbHNvIGluaXRpYWxpemVkIGluIHRoZSBhc3lu YyBxdWV1ZQo+ID4gPiA+ICAgICAgIGluZm8gPSBpZmJkZXYtPmhlbHBlci5mYmRldjsKPiA+ID4g PiArICAgICBpZiAoaW5mbyA9PSBOVUxMKQo+ID4gPiA+ICsgICAgICAgICAgICByZXR1cm4gZmFs c2U7Cj4gPiA+ID4gICAgICAgaWYgKCFpbmZvLT5zY3JlZW5fYmFzZSkKPiA+IAo+ID4gU28gaWYg dGhlcmUncyBpbmRlZWQgYSByYWNlIGJldHdlZW4gZmJkZXYgaW5pdGlhbGl6YXRpb24gYW5kIHRo ZSBjYWxsIHRvCj4gPiBpbnRlbF9mYmRldl9yZXN0b3JlX21vZGUoKSAob24gbGFzdGNsb3NlKSwg dGhlcmUncyBtb3JlIHRoYXQgY2FuIGdvIGF3cnk6Cj4gPiAtIGludGVsX2ZiZGV2X3Jlc3RvcmVf bW9kZSgpIGRlcmVmZXJlbmNlcyBpZmJkZXYtPmZiLT5vYmoKPiA+IC0gaXQgY2FsbHMgX19kcm1f YXRvbWljX2hlbHBlcl9zZXRfY29uZmlnKCkgd2hpY2ggV0FSTnMgaWYgaWZiZGV2LT5mYiBpcyBO VUxMCj4gPiAtIGl0IGNhbGxzIGRybV9mYl9oZWxwZXJfc2V0X3BhcigpIHdoaWNoIGRlcmVmZXJl bmNlcyBpZmJkZXYtPmhlbHBlci5mYmRldgo+ID4gCj4gPiBJbnN0ZWFkIG9mIGNoZWNraW5nIGFs bCB0aGF0IGl0J3MgcHJvYmFibHkgc2ltcGxlciB0byBjYWxsCj4gPiBhc3luY19zeW5jaHJvbml6 ZV9mdWxsKCkgYXQgdGhlIGJlZ2lubmluZyBvZiBpbnRlbF9mYmRldl9yZXN0b3JlX21vZGUoKSwK PiA+IGFzIExpIFdlaW5hbiBzdWdnZXN0ZWQuIEknbGwgc3VibWl0IHRoZSBjb3JyZXNwb25kaW5n IG9uZS1saW5lciBwYXRjaAo+ID4gdG9tb3Jyb3cgaWYgbm9vbmUgZWxzZSBkb2VzLgo+ID4gCj4g PiBDaHJpcycgcGF0Y2ggYWxzbyBtb2RpZmllZCBpbnRlbF9mYmRldl9zZXRfc3VzcGVuZCgpIGFz IHdlbGwgYXMKPiA+IGludGVsX2ZiZGV2X291dHB1dF9wb2xsX2NoYW5nZWQoKSwgbm90IHN1cmUg aWYgdGhlc2UgYXJlIHJhY3kgYXMgd2VsbC4KPiA+IEF0IGxlYXN0IHRoZSBzdGFjayB0cmFjZXMg cG9zdGVkIGJ5IExpIFdlaW5hbiBhbmQgR3VzdGF2IEbDpGdlcmxpbmQKPiA+IG9ubHkgaW5kaWNh dGUgdGhhdCBsYXN0Y2xvc2UgaXMgcmFjeS4KPiAKPiBXZSBjYWxsZWQgc2V0LXN1c3BlbmQgaW50 ZXJuYWxseSwgYnV0IHdlIGRvbid0IGRvIGFueSBjaGVja3MgYmVmb3JlCj4gaGFuZC4gSSB3YXMg Y29uY2VybmVkIHdlIG1heSBiZSBhYmxlIHRvIGdldCBpbnRvIGEgc2l0dWF0aW9uIHdoZXJlCj4g LmZiX3Byb2JlIGZhaWxzIGFuZCBsZWF2ZXMgYSBkYW5nbGluZyBkZXZfcHJpdi0+aWZiZGV2IGZv ciB3aGljaCB3ZQo+IHdvdWxkIHRoZW4gdHJpcCBvdmVyIHRoZSBOVUxMIGluZm8tPnNjcmVlbl9i YXNlLiBTbyBJIHdhcyBsb29raW5nIGZvciBhCj4gc3VpdGFibGUgZ3VhcmQuCgpZZXMsIGxvb2tp bmcgYXQgdGhpcyB3aXRoIGEgZnJlc2ggcGFpciBvZiBleWViYWxscyBJIHRoaW5rIHlvdSB3ZXJl CnRvdGFsbHkgcmlnaHQsIGk5MTVfcG1fb3BzIGlzIGRlY2xhcmVkIGFzIHBhcnQgb2YgaTkxNV9w Y2lfZHJpdmVyIGFuZAppdCBtaWdodCBpbmRlZWQgaGFwcGVuIHRoYXQgaTkxNV9wbV9zdXNwZW5k KCkgaXMgY2FsbGVkIGJlZm9yZSB0aGUgZmJkZXYKaXMgZnVsbHkgaW5pdGlhbGl6ZWQuCgpBcyBm b3IgaW50ZWxfZmJkZXZfb3V0cHV0X3BvbGxfY2hhbmdlZCgpLCB0aGVyZSdzIGV2ZW4gYSBjb21t ZW50IGluCmk5MTVfbG9hZF9tb2Rlc2V0X2luaXQoKSBzdGF0aW5nIHRoYXQgaG90cGx1ZyBldmVu dHMgbWlnaHQgb2NjdXIKZHVyaW5nIGZkYmV2IGluaXRpYWwgY29uZmlnLgoKQmVsb3cgcGF0Y2gg YWRkcyB0aGUgcmVxdWlzaXRlIGFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKSB0byB0aGUgdGhyZWUK ZnVuY3Rpb25zIHRoYXQgeW91IGFsc28gbW9kaWZpZWQgYW5kIHVwZGF0ZXMgdGhhdCBjb21tZW50 LgoKSG93ZXZlciBBRkFJQ1QgYSBjb3JuZXIgY2FzZSByZW1haW5zIHdoZXJlIHdlJ3JlIHN0aWxs IHZ1bG5lcmFibGUgdG8gcmFjZXM6CmFzeW5jX3NjaGVkdWxlKCkgcnVucyBzeW5jaHJvbm91c2x5 ICJpZiB3ZSdyZSBvdXQgb2YgbWVtb3J5IG9yIGlmIHRoZXJlJ3MKdG9vIG11Y2ggd29yayBwZW5k aW5nIGFscmVhZHkiIChzZWUgX19hc3luY19zY2hlZHVsZSgpIGluIGtlcm5lbC9hc3luYy5jKS4K SW4gdGhpcyBjYXNlIG5vIGVudHJ5IGlzIGFkZGVkIHRvIHRoZSBwZW5kaW5nIGxpc3QgYW5kCmFz eW5jX3N5bmNocm9uaXplX2Z1bGwoKSBtaWdodCB0aGVvcmV0aWNhbGx5IHJldHVybiBiZWZvcmUg dGhlIHN5bmNocm9ub3VzbHkKZXhlY3V0ZWQgZnVuY3Rpb24gaGFzIGZpbmlzaGVkLgoKVGhlIGV4 aXN0aW5nIGNhbGwgdG8gYXN5bmNfc3luY2hyb25pemVfZnVsbCgpIGluIGludGVsX2ZiZGV2X2Zp bmkoKQpzZWVtcyB0byBiZSBzdXNjZXB0aWJsZSB0byB0aGUgc2FtZSByYWNlIGNvbmRpdGlvbiwg YnV0IGl0J3MgcHJvYmFibHkKdmVyeSBoYXJkIHRvIHRyaWdnZXIgaXQuIChVbmxvYWQgdGhlIG1v ZHVsZSBiZWZvcmUgdGhlIGZiZGV2IGlzIGZ1bGx5CmluaXRpYWxpemVkLikKClRvIG1ha2UgaXQg YnVsbGV0IHByb29mIHdlIGNvdWxkIGRlY2xhcmUgYSBjb21wbGV0aW9uIGluIGludGVsX2ZiZGV2 LmMKYW5kIHdhaXQgZm9yIHRoYXQgaW5zdGVhZC4gT3BpbmlvbnM/CgpUaGFua3MsCgpMdWthcwoK LS0gPjggLS0KClN1YmplY3Q6IFtQQVRDSF0gZHJtL2k5MTU6IEZpeCByYWNlcyBvbiBmYmRldgoK VGhlIC0+bGFzdGNsb3NlIGNhbGxiYWNrIGludm9rZXMgaW50ZWxfZmJkZXZfcmVzdG9yZV9tb2Rl KCkgYW5kIGhhcwpiZWVuIHdpdG5lc3NlZCB0byBydW4gYmVmb3JlIGludGVsX2ZiZGV2X2luaXRp YWxfY29uZmlnX2FzeW5jKCkKaGFzIGZpbmlzaGVkLgoKV2UgbWlnaHQgbGlrZXdpc2UgcmVjZWl2 ZSBob3RwbHVnIGV2ZW50cyBvciBiZSBzdXNwZW5kZWQgYmVmb3JlCndlJ3ZlIGhhZCBhIGNoYW5j ZSB0byBmdWxseSBzZXQgdXAgdGhlIGZiZGV2LgoKRml4IGJ5IHdhaXRpbmcgZm9yIHRoZSBhc3lu Y2hyb25vdXMgdGhyZWFkIHRvIGZpbmlzaC4KCkJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05MzU4MApSZXBvcnRlZC1ieTogR3VzdGF2IEbDg+KC rGdlcmxpbmQgPGd1c3Rhdi5mYWdlcmxpbmRAZ21haWwuY29tPgpSZXBvcnRlZC1ieTogIkxpLCBX ZWluYW4gWiIgPHdlaW5hbi56LmxpQGludGVsLmNvbT4KQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwpTaWduZWQtb2Zm LWJ5OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RtYS5jICAgIHwgOCArKystLS0tLQogZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZmJkZXYuYyB8IDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKaW5kZXggYTBmNTY1OS4uYTc2YjUy OCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYworKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jCkBAIC00MzcsMTEgKzQzNyw5IEBAIHN0YXRpYyBp bnQgaTkxNV9sb2FkX21vZGVzZXRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQogCSAqIFNv bWUgcG9ydHMgcmVxdWlyZSBjb3JyZWN0bHkgc2V0LXVwIGhwZCByZWdpc3RlcnMgZm9yIGRldGVj dGlvbiB0bwogCSAqIHdvcmsgcHJvcGVybHkgKGxlYWRpbmcgdG8gZ2hvc3QgY29ubmVjdGVkIGNv bm5lY3RvciBzdGF0dXMpLCBlLmcuIFZHQQogCSAqIG9uIGdtNDUuICBIZW5jZSB3ZSBjYW4gb25s eSBzZXQgdXAgdGhlIGluaXRpYWwgZmJkZXYgY29uZmlnIGFmdGVyIGhwZAotCSAqIGlycXMgYXJl IGZ1bGx5IGVuYWJsZWQuIE5vdyB3ZSBzaG91bGQgc2NhbiBmb3IgdGhlIGluaXRpYWwgY29uZmln Ci0JICogb25seSBvbmNlIGhvdHBsdWcgaGFuZGxpbmcgaXMgZW5hYmxlZCwgYnV0IGR1ZSB0byBz Y3Jld2VkLXVwIGxvY2tpbmcKLQkgKiBhcm91bmQga21zL2ZiZGV2IGluaXQgd2UgY2FuJ3QgcHJv dGVjdCB0aGUgZmRiZXYgaW5pdGlhbCBjb25maWcKLQkgKiBzY2FubmluZyBhZ2FpbnN0IGhvdHBs dWcgZXZlbnRzLiBIZW5jZSBkbyB0aGlzIGZpcnN0IGFuZCBpZ25vcmUgdGhlCi0JICogdGlueSB3 aW5kb3cgd2hlcmUgd2Ugd2lsbCBsb29zZSBob3RwbHVnIG5vdGlmYWN0aW9ucy4KKwkgKiBpcnFz IGFyZSBmdWxseSBlbmFibGVkLiBXZSBwcm90ZWN0IHRoZSBmYmRldiBpbml0aWFsIGNvbmZpZyBz Y2FubmluZworCSAqIGFnYWluc3QgaG90cGx1ZyBldmVudHMgYnkgd2FpdGluZyBpbiBpbnRlbF9m YmRldl9vdXRwdXRfcG9sbF9jaGFuZ2VkCisJICogdW50aWwgdGhlIGFzeW5jaHJvbm91cyB0aHJl YWQgaGFzIGZpbmlzaGVkLgogCSAqLwogCWludGVsX2ZiZGV2X2luaXRpYWxfY29uZmlnX2FzeW5j KGRldik7CiAKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCmluZGV4IDA5ODQwZjQuLjIwMDJi MTMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwpAQCAtNzQ5LDYgKzc0OSw3IEBAIHZv aWQgaW50ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHN0 YXRlLCBib29sIHN5bmNocm9ub3VzCiAJc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSBkZXZf cHJpdi0+ZmJkZXY7CiAJc3RydWN0IGZiX2luZm8gKmluZm87CiAKKwlhc3luY19zeW5jaHJvbml6 ZV9mdWxsKCk7CiAJaWYgKCFpZmJkZXYpCiAJCXJldHVybjsKIApAQCAtNzk1LDYgKzc5Niw4IEBA IHZvaWQgaW50ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50 IHN0YXRlLCBib29sIHN5bmNocm9ub3VzCiB2b2lkIGludGVsX2ZiZGV2X291dHB1dF9wb2xsX2No YW5nZWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKIHsKIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOworCisJYXN5bmNfc3luY2hyb25pemVfZnVs bCgpOwogCWlmIChkZXZfcHJpdi0+ZmJkZXYpCiAJCWRybV9mYl9oZWxwZXJfaG90cGx1Z19ldmVu dCgmZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIpOwogfQpAQCAtODA2LDYgKzgwOSw3IEBAIHZvaWQg aW50ZWxfZmJkZXZfcmVzdG9yZV9tb2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCiAJc3RydWN0 IGludGVsX2ZiZGV2ICppZmJkZXYgPSBkZXZfcHJpdi0+ZmJkZXY7CiAJc3RydWN0IGRybV9mYl9o ZWxwZXIgKmZiX2hlbHBlcjsKIAorCWFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKTsKIAlpZiAoIWlm YmRldikKIAkJcmV0dXJuOwogCi0tIAoxLjguNS4yIChBcHBsZSBHaXQtNDgpCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=