From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755214AbcBGWtV (ORCPT ); Sun, 7 Feb 2016 17:49:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58752 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbcBGWtU (ORCPT ); Sun, 7 Feb 2016 17:49:20 -0500 Date: Sun, 7 Feb 2016 14:49:19 -0800 From: Greg KH To: John Stultz Cc: lkml , San Mehat , Android Kernel Team Subject: Re: [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak Message-ID: <20160207224919.GA29549@kroah.com> References: <1454134058-16466-1-git-send-email-john.stultz@linaro.org> <1454134058-16466-4-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454134058-16466-4-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 10:07:32PM -0800, John Stultz wrote: > From: San Mehat > > As it turns out, the CONFIG_PROFILING interfaces leak a > task struct if the notifier chain returns NOTIFY_OK.. doh. > > This patch reworks lowmemkiller to use the new generic task > free notifier chain. > > Cc: Android Kernel Team > Cc: Greg KH > Signed-off-by: San Mehat > [jstultz: Commit subject tweak] > Signed-off-by: John Stultz > --- > drivers/staging/android/lowmemorykiller.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > index 8b5a4a8..806643d 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -40,7 +40,6 @@ > #include > #include > #include > -#include > #include > > static u32 lowmem_debug_level = 1; > -- > 1.9.1 The changelog comment seems a bit "odd" when looking at the patch here. Is the patch really correct? The changelog? totally confused, greg k-h