From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSZwS-00087M-69 for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSZwR-0004oI-2B for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:36 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:34514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSZwQ-0004o2-N5 for qemu-devel@nongnu.org; Sun, 07 Feb 2016 19:44:34 -0500 Date: Mon, 8 Feb 2016 10:33:23 +1000 From: David Gibson Message-ID: <20160208003323.GB3702@voom> References: <1452860484-12236-1-git-send-email-david@gibson.dropbear.id.au> <1452860484-12236-4-git-send-email-david@gibson.dropbear.id.au> <87ziviw1k7.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MW5yreqqjyrRcusr" Content-Disposition: inline In-Reply-To: <87ziviw1k7.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCHv3 3/4] Allow ISA bus to be configured out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mst@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, agraf@suse.de --MW5yreqqjyrRcusr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 03, 2016 at 11:06:16AM +0100, Markus Armbruster wrote: > David Gibson writes: >=20 > > Currently, the code to handle the legacy ISA bus is always included in > > qemu. However there are lots of platforms that don't include ISA legacy > > devies, and quite a few that have never used ISA legacy devices at all. > > > > This patch allows the ISA bus code to be disabled in the configuration = for > > platforms where it doesn't make sense. > > > > For now, the default configs are adjusted to include ISA on all platfor= ms > > including PCI: anything with PCI can at least in principle add an i82378 > > PCI->ISA bridge. Also, CONFIG_IDE_CORE which is already in pci.mak > > requires ISA support. > > > > We also explicitly enable ISA on some other non-PCI platforms which inc= lude > > ISA devices. We may want to pare this down in future. >=20 > Impact? Please list the targets that lose ISA because of this > patch. Ok, will do. >=20 > > Signed-off-by: David Gibson > > Acked-by: Michael S. Tsirkin > > --- > > default-configs/moxie-softmmu.mak | 1 + > > default-configs/pci.mak | 2 ++ > > default-configs/sparc-softmmu.mak | 1 + > > default-configs/unicore32-softmmu.mak | 1 + > > hw/isa/Makefile.objs | 2 +- > > 5 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/default-configs/moxie-softmmu.mak b/default-configs/moxie-= softmmu.mak > > index 1a95476..3886275 100644 > > --- a/default-configs/moxie-softmmu.mak > > +++ b/default-configs/moxie-softmmu.mak > > @@ -1,5 +1,6 @@ > > # Default configuration for moxie-softmmu > > =20 > > +CONFIG_ISA_BUS=3Dy > > CONFIG_MC146818RTC=3Dy > > CONFIG_SERIAL=3Dy > > CONFIG_VGA=3Dy >=20 > Uh, PATCH 2 excepted moxie from "add CONFIG_SERIAL_ISA to every config > that has CONFIG_SERIAL", but now you're giving it an ISA bus. Please > explain. Oops. It's the other patch that was wrong, moxie includes an ISA only RTC, so it does need to include ISA, and should also include ISA_SERIAL. > > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > > index f250119..bcf18f0 100644 > > --- a/default-configs/pci.mak > > +++ b/default-configs/pci.mak > > @@ -1,4 +1,6 @@ > > CONFIG_PCI=3Dy > > +# For now, IDE_CORE requires ISA, so we enable it here >=20 > You mean CONFIG_IDE_CORE? If yes, please spell it out, so grep finds > it. Ok, will do. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --MW5yreqqjyrRcusr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWt+JSAAoJEGw4ysog2bOShdcP/1nCy4wR8XK35kbuVnWf6VQN 3j38SwwsIwkLaI4VsjVu632/WunOQp8ykbSDY14KnjxrzU+HDoGBA0IljPlmHrB2 ylrzc955bdG0g0131wX9Jq/Vzm5LZPcgimAp2t8feS+oD6ePBWDZMXFRKj/XyVRM 4aSg+0RghoQDjjvdrnxFNKbLrrcjiXq3jAR7/A3ZpTDd3ZSMIzpRN+YzNF0bm4Vt zx16eGG19CSYtvyTtVjCPqyY/heBZVea5XVARYjuYRbDpaFWDHp2LMougNSUH4r1 AuQT9aW98cEWezlfJF75iYoeYk7hhQWw+ByXieA2wAikuD3VtgxGqukwcF2oUj/A hMdEWcymBEn6dmFU5orcp7ZHkA5MxdnUMF3nUnG1xQqy29MD9j6+mSF0xfG4smN3 e4bJs4aZ927Zy48yOMFdk1xomJqa+if9aARccbg15tYZccliIF/WJxCD5aBCYyR2 vX4Y+NqRtyaxyMqO42d2orw+VuhtpdrjMJCTPnTFckD+odYl5zat5YfCXdOyImi7 vRUX3pHv5m50PiVT1nEgF8uUKzkH8azhunuQL6ZUkFPMCD6tiJdlQAQ9tOs6puuJ dPEudAZGK2kuMFLMmwUiVxt49aiEAnmueG0/KKs2W2OyLTIm6RCd8VAtjtZA+BdG aYwmP/S0JJGq4ZADy913 =Plw/ -----END PGP SIGNATURE----- --MW5yreqqjyrRcusr--