All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Viktorin <viktorin@rehivetech.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 0/9] pci cleanup and blacklist rework
Date: Mon, 8 Feb 2016 14:31:53 +0100	[thread overview]
Message-ID: <20160208143153.0a01f7fe@pcviktorin.fit.vutbr.cz> (raw)
In-Reply-To: <1454078953-23744-1-git-send-email-david.marchand@6wind.com>

Hello David,

I am confused a bit. I started to review the "[PATCH 0/9] prepare for rte_device
/ rte_driver" series and then I've noticed there are 2 patch series having "pci:
no need for dynamic tailq init" patch there. But then, there is this v2 that does
not have this patch. What is the right one? What should I look at. Is related?

Regards
Jan

On Fri, 29 Jan 2016 15:49:04 +0100
David Marchand <david.marchand@6wind.com> wrote:

> Before 2.2.0 release, while preparing for more changes in eal (and fixing
> a problem reported by Roger M. [1]), I came up with this (part of) patchset
> that tries to make the pci code more compact and easier to read.
> 
> I ended up introducing some hooks in the pci layer to customize pci
> blacklist / whitelist handling and make it possible to automatically
> bind / unbind pci devices to igb_uio (or equivalent) when attaching
> a device.
> 
> I am still not really happy:
> - the pci blacklist / whitelist makes me think we should let the
>   application tell eal which resources to use and get rid of the
>   unconditional pci scan code, which means removing rte_eal_pci_probe()
>   from rte_eal_init(), and remove rte_eal_dev_init() for vdevs,
> - the more I look at this, the more I think automatic bind / unbind for
>   pci devices should be called from the pmd context. The drivers know best
>   what they require and what they want to do with the resources passed by
>   the eal (see the drv_flags / RTE_KDRV_NONE / rte_eal_pci_map_device stuff
>   for virtio pmd).
>   This behaviour would still be optional, on a per-device basis.
> 
> So, I think that these hooks are not that good of an idea and I kept
> them private for now, but anyway, sending this for comments.
> 
> 
> Changes since v1:
> - split the initial patchset. This current patchset now depends on
>   [2] sent separately which should be applied first,
> - introduced hooks in pci common code,
> - implemented automatic bind / unbind for "uio" pci devices
> 
> 
> [1] http://dpdk.org/ml/archives/dev/2015-November/028140.html
> [2] http://dpdk.org/ml/archives/dev/2016-January/032387.html
> 



-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic

  parent reply	other threads:[~2016-02-08 13:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 15:27 [PATCH 0/9] pci cleanup and blacklist rework David Marchand
2016-01-22 15:27 ` [PATCH 1/9] pci: no need for dynamic tailq init David Marchand
2016-01-22 15:27 ` [PATCH 2/9] pci: add internal device list helpers David Marchand
2016-01-22 15:27 ` [PATCH 3/9] pci: minor cleanup David Marchand
2016-01-22 15:27 ` [PATCH 4/9] pci: rework sysfs parsing for driver David Marchand
2016-01-22 15:27 ` [PATCH 5/9] pci: factorize probe/detach code David Marchand
2016-01-22 15:27 ` [PATCH 6/9] pci: cosmetic change David Marchand
2016-01-22 15:27 ` [PATCH 7/9] pci: factorize driver search David Marchand
2016-01-22 15:27 ` [PATCH 8/9] pci: remove driver lookup from detach David Marchand
2016-01-22 15:27 ` [PATCH 9/9] pci: blacklist only in global probe function David Marchand
2016-01-27 13:07 ` [PATCH 0/9] pci cleanup and blacklist rework David Marchand
2016-01-29 14:49 ` [PATCH v2 " David Marchand
2016-01-29 14:49   ` [PATCH v2 1/9] pci: add internal device list helpers David Marchand
2016-01-29 14:49   ` [PATCH v2 2/9] pci/linux: minor cleanup David Marchand
2016-01-29 14:49   ` [PATCH v2 3/9] pci/linux: rework sysfs parsing for driver David Marchand
2016-01-29 14:49   ` [PATCH v2 4/9] pci: factorize probe/detach code David Marchand
2016-01-29 14:49   ` [PATCH v2 5/9] pci: cosmetic change David Marchand
2016-01-29 14:49   ` [PATCH v2 6/9] pci: factorize driver search David Marchand
2016-01-29 14:49   ` [PATCH v2 7/9] pci: remove driver lookup from detach David Marchand
2016-01-29 14:49   ` [PATCH v2 8/9] pci: implement blacklist using a hook David Marchand
2016-01-29 14:49   ` [PATCH v2 9/9] pci: implement automatic bind/unbind David Marchand
2016-02-03  9:26     ` Ivan Boule
2016-02-08 13:31   ` Jan Viktorin [this message]
2016-02-09  8:39     ` [PATCH v2 0/9] pci cleanup and blacklist rework David Marchand
2016-03-16 16:07   ` Jan Viktorin
2016-03-22 10:24     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208143153.0a01f7fe@pcviktorin.fit.vutbr.cz \
    --to=viktorin@rehivetech.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.