From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbcBHR2e (ORCPT ); Mon, 8 Feb 2016 12:28:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43546 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbcBHR2c (ORCPT ); Mon, 8 Feb 2016 12:28:32 -0500 Date: Mon, 8 Feb 2016 09:28:31 -0800 From: Greg KH To: Vladimir Murzin Cc: arnd@arndb.de, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Message-ID: <20160208172831.GB6715@kroah.com> References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> <56B87928.7020803@arm.com> <20160208165226.GA11593@kroah.com> <56B8CDC5.5010504@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B8CDC5.5010504@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote: > On 08/02/16 16:52, Greg KH wrote: > > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote: > >> On 07/02/16 07:11, Greg KH wrote: > >>>> + > >>>> +#define SERIAL_NAME "ttyS" > >>> > >>> You can't be "ttyS", there's already a serial port named that, please > >>> use a unique name and a new major/minor number (dynamic ideally). > >>> > >> > >> Hi Greg, > >> > >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it > >> back if you prefer that, but I'd be glad to know what I've been missing? > >> > >> [1] https://lkml.org/lkml/2015/12/13/8 > > > > Yeah, I was wrong, sorry about that, my fault. > > > > I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"? Please use ttyMPS. > P.S. > Any chance you could look at the rest of the patch? It's long gone from my queue, sorry, you'll have to resend it. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Date: Mon, 8 Feb 2016 09:28:31 -0800 Message-ID: <20160208172831.GB6715@kroah.com> References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> <56B87928.7020803@arm.com> <20160208165226.GA11593@kroah.com> <56B8CDC5.5010504@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56B8CDC5.5010504-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vladimir Murzin Cc: arnd-r2nGTMty4D4@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jslaby-AlSwsSmVLrQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote: > On 08/02/16 16:52, Greg KH wrote: > > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote: > >> On 07/02/16 07:11, Greg KH wrote: > >>>> + > >>>> +#define SERIAL_NAME "ttyS" > >>> > >>> You can't be "ttyS", there's already a serial port named that, please > >>> use a unique name and a new major/minor number (dynamic ideally). > >>> > >> > >> Hi Greg, > >> > >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it > >> back if you prefer that, but I'd be glad to know what I've been missing? > >> > >> [1] https://lkml.org/lkml/2015/12/13/8 > > > > Yeah, I was wrong, sorry about that, my fault. > > > > I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"? Please use ttyMPS. > P.S. > Any chance you could look at the rest of the patch? It's long gone from my queue, sorry, you'll have to resend it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Mon, 8 Feb 2016 09:28:31 -0800 Subject: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver In-Reply-To: <56B8CDC5.5010504@arm.com> References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> <56B87928.7020803@arm.com> <20160208165226.GA11593@kroah.com> <56B8CDC5.5010504@arm.com> Message-ID: <20160208172831.GB6715@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote: > On 08/02/16 16:52, Greg KH wrote: > > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote: > >> On 07/02/16 07:11, Greg KH wrote: > >>>> + > >>>> +#define SERIAL_NAME "ttyS" > >>> > >>> You can't be "ttyS", there's already a serial port named that, please > >>> use a unique name and a new major/minor number (dynamic ideally). > >>> > >> > >> Hi Greg, > >> > >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it > >> back if you prefer that, but I'd be glad to know what I've been missing? > >> > >> [1] https://lkml.org/lkml/2015/12/13/8 > > > > Yeah, I was wrong, sorry about that, my fault. > > > > I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"? Please use ttyMPS. > P.S. > Any chance you could look at the rest of the patch? It's long gone from my queue, sorry, you'll have to resend it. thanks, greg k-h