From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbcBHSTd (ORCPT ); Mon, 8 Feb 2016 13:19:33 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40403 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbcBHSTc (ORCPT ); Mon, 8 Feb 2016 13:19:32 -0500 Date: Mon, 8 Feb 2016 18:19:08 +0000 From: Mark Brown To: Laxman Dewangan Cc: Thomas Gleixner , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, gregkh@linuxfoundation.org, a.zummo@towertech.it, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Message-ID: <20160208181908.GM7265@sirena.org.uk> References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> <1454769447-785-2-git-send-email-ldewangan@nvidia.com> <20160208145550.GE7265@sirena.org.uk> <56B8C484.7000309@nvidia.com> <20160208165912.GK7265@sirena.org.uk> <56B8C8B4.4050207@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F7w+4yMapWozG0Ib" Content-Disposition: inline In-Reply-To: <56B8C8B4.4050207@nvidia.com> X-Cookie: All work and no pay makes a housewife. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --F7w+4yMapWozG0Ib Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote: > Adding Thomas in the discussion. > >This does not explain why anyone would ever want to use this interface > >(which was my question), why would anyone ever want to do this as a > >separate step? > OK, so you want to say that irq_domain_remove() should take care of doing > unmap also? My main focus is on the regmap-irq interface you are trying to add - why would a user of this interface want to do this as a separate step (which would require changing all the existing users...)? We're providing an interface to get the virq mapped to a particular interrupt in the device, it's not obvious that that is an allocation and it certainly wasn't the intention (this code predates us using domains). > So fix need to go in the irq_domain_remove() to unamp before actually > destroying the irq domain? That's one option, but you could also do this at the regmap-irq level. --F7w+4yMapWozG0Ib Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWuNwbAAoJECTWi3JdVIfQO18H/3hiMKQ+QTM4waCBdJpIUpGm B0qZ5belH10BZbpD8mKfKDbvwqudDCsK+5UJcBrhchkp7cT+IITBuyhJ8JAGWVpG bm850l2vQYaKCvARp0BmplppMe3FZTwYj1ASWYGBR/xMxBT1f0AyqlHYQKBQj8HG tKPlSMORwCI6kT/jqZ6FHIWjYk7/wxrYnnaiyqRfgIa6xNcLuer5wD8L2WCpPdLt svqcLULXDiJ7RRPcRybg1FT+Av2KLK0u28mUNvaOBvlBJLU+FriAYhc+Pd6YYBks MBb7GTJNbT3CvPI0RWWvh3/bi4nOp/7sbqjRcf05MVjNCEXxEicVSrMIdhzuJoQ= =gC49 -----END PGP SIGNATURE----- --F7w+4yMapWozG0Ib-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk. [2400:8900::f03c:91ff:fedb:4f4]) by gmr-mx.google.com with ESMTPS id ff2si1782828pad.2.2016.02.08.10.19.33 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 08 Feb 2016 10:19:33 -0800 (PST) Date: Mon, 8 Feb 2016 18:19:08 +0000 From: Mark Brown To: Laxman Dewangan Cc: Thomas Gleixner , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, gregkh@linuxfoundation.org, a.zummo@towertech.it, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Message-ID: <20160208181908.GM7265@sirena.org.uk> References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> <1454769447-785-2-git-send-email-ldewangan@nvidia.com> <20160208145550.GE7265@sirena.org.uk> <56B8C484.7000309@nvidia.com> <20160208165912.GK7265@sirena.org.uk> <56B8C8B4.4050207@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F7w+4yMapWozG0Ib" In-Reply-To: <56B8C8B4.4050207@nvidia.com> Subject: [rtc-linux] Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , --F7w+4yMapWozG0Ib Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote: > Adding Thomas in the discussion. > >This does not explain why anyone would ever want to use this interface > >(which was my question), why would anyone ever want to do this as a > >separate step? > OK, so you want to say that irq_domain_remove() should take care of doing > unmap also? My main focus is on the regmap-irq interface you are trying to add - why would a user of this interface want to do this as a separate step (which would require changing all the existing users...)? We're providing an interface to get the virq mapped to a particular interrupt in the device, it's not obvious that that is an allocation and it certainly wasn't the intention (this code predates us using domains). > So fix need to go in the irq_domain_remove() to unamp before actually > destroying the irq domain? That's one option, but you could also do this at the regmap-irq level. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. --F7w+4yMapWozG0Ib Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWuNwbAAoJECTWi3JdVIfQO18H/3hiMKQ+QTM4waCBdJpIUpGm B0qZ5belH10BZbpD8mKfKDbvwqudDCsK+5UJcBrhchkp7cT+IITBuyhJ8JAGWVpG bm850l2vQYaKCvARp0BmplppMe3FZTwYj1ASWYGBR/xMxBT1f0AyqlHYQKBQj8HG tKPlSMORwCI6kT/jqZ6FHIWjYk7/wxrYnnaiyqRfgIa6xNcLuer5wD8L2WCpPdLt svqcLULXDiJ7RRPcRybg1FT+Av2KLK0u28mUNvaOBvlBJLU+FriAYhc+Pd6YYBks MBb7GTJNbT3CvPI0RWWvh3/bi4nOp/7sbqjRcf05MVjNCEXxEicVSrMIdhzuJoQ= =gC49 -----END PGP SIGNATURE----- --F7w+4yMapWozG0Ib--