From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932489AbcBHWQP (ORCPT ); Mon, 8 Feb 2016 17:16:15 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:55516 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932266AbcBHWQL (ORCPT ); Mon, 8 Feb 2016 17:16:11 -0500 Date: Mon, 8 Feb 2016 23:16:05 +0100 From: Sam Ravnborg To: Nicolas Pitre Cc: Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Rusty Russell Subject: Re: [PATCH 2/6] allow for per-symbol configurable EXPORT_SYMBOL() Message-ID: <20160208221605.GB13832@ravnborg.org> References: <1454963315-20468-1-git-send-email-nicolas.pitre@linaro.org> <1454963315-20468-3-git-send-email-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454963315-20468-3-git-send-email-nicolas.pitre@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=VPZ9547X c=1 sm=1 tr=0 a=Ij76tQDYWdb01v2+RnYW5w==:117 a=Ij76tQDYWdb01v2+RnYW5w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=c4UEv9zCUgGi0Ydi0iYA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 03:28:31PM -0500, Nicolas Pitre wrote: > Similar to include/generated/autoconf.h, include/generated/expsyms.h will > contain a list of defines for each EXPORT_SYMBOL() that we want active. > The format is: > > #define __EXPSYM_ 1 Please spell it out. EXP could be EXPECT... > + $(Q)touch include/generated/expsyms.h Same goes here. Make it explicit what this is about. It is obvious today that "exp" is synonym for export_symbol. But in one year less so. Same goes for CONFIG_ symbol etc. Sam >