From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aT3iZ-00035b-0e for kexec@lists.infradead.org; Tue, 09 Feb 2016 08:32:15 +0000 Date: Tue, 9 Feb 2016 09:31:50 +0100 From: Petr Tesarik Subject: Re: [PATCH] makedumpfile: readpage_elf: handle 0-pages not stored in the ELF file Message-ID: <20160209093150.35da61c2@hananiah.suse.cz> In-Reply-To: <20160202070044.GN6903@ycc.fr> References: <20160122233514.GA25777@ycc.fr> <0910DD04CBD6DE4193FCF86B9C00BE9701E19AFB@BPXM01GP.gisp.nec.co.jp> <20160127085821.3be424e1@hananiah.suse.cz> <20160127103741.0e4fec81@hananiah.suse.cz> <0910DD04CBD6DE4193FCF86B9C00BE9701E1B252@BPXM01GP.gisp.nec.co.jp> <20160201130042.5c83f7ae@hananiah.suse.cz> <0910DD04CBD6DE4193FCF86B9C00BE9701E1B6CE@BPXM01GP.gisp.nec.co.jp> <20160202070044.GN6903@ycc.fr> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Ivan Delalande Cc: Atsushi Kumagai , "kexec@lists.infradead.org" On Tue, 2 Feb 2016 08:00:44 +0100 Ivan Delalande wrote: > On Tue, Feb 02, 2016 at 06:48:17AM +0000, Atsushi Kumagai wrote: > > >Anyway, are you going to take the patch by Ivan, or my patch (after I > > >remove exclude_nodata_pages)? > > > > Ivan's patch is necessary to follow the ELF specification, but also > > your patch (with exclude_nodata_pages) should be merged. > > The two patches have different approach to expand struct pt_load_segment, > > hence could you manage both work ? > > > > Ivan, your v2 patch has no problems, but could I leave this work to Petr > > since the two patches touch the same area ? > > Sure, this sounds reasonable. Hello, just a short status update. I haven't forgotten this patch, but I've had some troubles reproducing the issue. To make sure I'm not on the wrong track, what happened when you tried to dump dmesg on the affected dump file without the patch? For me, I crafted a dump file which causes a segfault. Did makedumpfile also terminate on SIGSEGV? Did it report an error? Or did it just produce wrong output? Thanks, Petr T _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec