From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755943AbcBIOOb (ORCPT ); Tue, 9 Feb 2016 09:14:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbcBIOOa (ORCPT ); Tue, 9 Feb 2016 09:14:30 -0500 Date: Tue, 9 Feb 2016 15:14:27 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 3/3] KVM: x86: consolidate different ways to test for in-kernel LAPIC Message-ID: <20160209141426.GC30378@potion.brq.redhat.com> References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454948146-35353-4-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-02-08 17:15+0100, Paolo Bonzini: > We had checks on vcpu->arch.apic being (non-)NULL, kvm_vcpu_has_lapic > (more optimized) and lapic_in_kernel. Replace everything with > lapic_in_kernel's name and kvm_vcpu_has_lapic's implementation. > > Signed-off-by: Paolo Bonzini > --- Nice, Reviewed-by: Radim Krčmář