Re: [PATCH v2 00/16] Common Dell SMBIOS API

From: "Michał Kępień" <kernel@kempniu.pl>
To: Darren Hart <dvhart@infradead.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Richard Purdie" <rpurdie@rpsys.net>,
	"Jacek Anaszewski" <j.anaszewski@samsung.com>,
	platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/16] Common Dell SMBIOS API
Date: Tue, 9 Feb 2016 15:15:49 +0100	[thread overview]
Message-ID: <20160209141549.GA7965@eudyptula.hq.kempniu.pl> (raw)
In-Reply-To: <20160208204646.GQ1779@malice.jf.intel.com>

> > > Most of my concerns were addressed by later patches in the series. I have pushed
> > > a version of this 1/7 fixed per lkp (linux/io.h) and 7/16 with a corrected body
> > > as I sent in reply to that patch. This is on my tree as the dell-smbios branch.

Thanks!

> > > 
> > > My only major concern is module load order dependencies. Inter-module
> > > dependencies are frowned upon with good reason, the kernel load ordering is
> > > non-deterministic and it's possible, for example, for dell-laptop to fail to
> > > find the symbols exported by dell-smbios under certain conditions.
> > > 
> > > I have worked around this in the past with things like the following:
> > > 
> > > #ifdef MODULE
> > > #ifdef CONFIG_FOO_MODULE
> > > 	if (request_module("foo"))
> > > 		return -ENODEV;
> > > #endif
> > > #endif
> > > 
> > > Something like the above may be necessary for dell-smbios in dell-laptop,
> > > dell-wmi, and dell-leds now that they depend on the dell-smbios exported
> > > functions.
> > > 
> > > Cc Greg in case there is a better way to handle this that I'm not aware of.
> > 
> > No need to request_module anything, the symbol resolution should pull
> > the dependant module in automagically when you do a 'modprobe',
> > otherwise the symbols would never be found.
> 
> OK, Thank you Greg. Based on this, I have no concerns that haven't been addressed in the
> pdx86/dell-smbios branch.
> 
> Michał, did you have any changes you wanted to make?

No, thanks, nothing new popped up.

-- 
Best regards,
Michał Kępień