From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbcBIPVK (ORCPT ); Tue, 9 Feb 2016 10:21:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56266 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbcBIPVH (ORCPT ); Tue, 9 Feb 2016 10:21:07 -0500 Date: Tue, 9 Feb 2016 16:21:00 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 2/3] KVM: x86: consolidate "has lapic" checks into irq.c Message-ID: <20160209152100.GD30378@potion.brq.redhat.com> References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-3-git-send-email-pbonzini@redhat.com> <20160209140543.GB30378@potion.brq.redhat.com> <56BA00C4.4040108@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56BA00C4.4040108@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-02-09 16:07+0100, Paolo Bonzini: > On 09/02/2016 15:05, Radim Krčmář wrote: >> 2016-02-08 17:15+0100, Paolo Bonzini: >>> int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) >>> + return true; >> >> Apart from int/bool mismatch, it returned 0 before and that was correct. >> > > So that means "return 0;" implies "Reviewed-by"? :) Yes. (Also for "false" and "bool kvm_cpu_has_pending_timer...". :])