From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964825AbcBISWu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 13:22:50 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:33625 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932670AbcBISWr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 13:22:47 -0500
Date: Tue, 9 Feb 2016 10:22:46 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver
Message-ID: <20160209182246.GD31787@kroah.com>
References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1455037283-106479-4-git-send-email-heikki.krogerus@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455037283-106479-4-git-send-email-heikki.krogerus@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 09, 2016 at 07:01:23PM +0200, Heikki Krogerus wrote:
> Driver for ACPI enumerated UCSI devices.

What does this mean?

What does the driver do?  Why would we care?

> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/usb/type-c/Kconfig     |  10 ++++
>  drivers/usb/type-c/Makefile    |   1 +
>  drivers/usb/type-c/ucsi_acpi.c | 133 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 144 insertions(+)
>  create mode 100644 drivers/usb/type-c/ucsi_acpi.c
> 
> diff --git a/drivers/usb/type-c/Kconfig b/drivers/usb/type-c/Kconfig
> index 02abd74..72b002e 100644
> --- a/drivers/usb/type-c/Kconfig
> +++ b/drivers/usb/type-c/Kconfig
> @@ -12,4 +12,14 @@ config TYPEC_UCSI
>  	  registers and data structures used to interface with the USB Type-C
>  	  connectors on a system.
>  
> +if TYPEC_UCSI
> +
> +config TYPEC_UCSI_ACPI
> +	tristate "UCSI ACPI Driver"
> +	depends on ACPI
> +	help
> +	  Driver for ACPI enumerated UCSI devices.

Worst help text ever :(

thanks,

greg k-h