All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: octeon: Add spaces around operators
Date: Wed, 10 Feb 2016 11:51:50 +0530	[thread overview]
Message-ID: <20160210062150.GC374@sudip-pc> (raw)
In-Reply-To: <20160210022615.GA12636@janani-Inspiron-3521>

On Tue, Feb 09, 2016 at 09:26:16PM -0500, Janani Ravichandran wrote:
> Add spaces around operators for better readability. Change suggested by
> checkpatch.
> 
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 82abaec..a08ea3f 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -419,7 +419,7 @@ dont_put_skbuff_in_hw:
>  		    cvmx_fau_fetch_and_add32(FAU_NUM_PACKET_BUFFERS_TO_FREE, 0);
>  	}
>  
> -	skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau+qos*4);
> +	skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau + qos *							4);

oops.. some thing went wrong here. why so much space before 4?

regards
sudip


  reply	other threads:[~2016-02-10  6:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10  2:26 [PATCH] staging: octeon: Add spaces around operators Janani Ravichandran
2016-02-10  6:21 ` Sudip Mukherjee [this message]
2016-02-10  8:44   ` [Outreachy kernel] " Janani Ravichandran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160210062150.GC374@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=janani.rvchndrn@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.