From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbcBJH0M (ORCPT ); Wed, 10 Feb 2016 02:26:12 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36613 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbcBJH0K (ORCPT ); Wed, 10 Feb 2016 02:26:10 -0500 Date: Wed, 10 Feb 2016 08:26:33 +0100 From: Daniel Vetter To: Andy Shevchenko Cc: Rasmus Villemoes , dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus() Message-ID: <20160210072633.GD11240@phenom.ffwll.local> Mail-Followup-To: Andy Shevchenko , Rasmus Villemoes , dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 08:41:17AM +0200, Andy Shevchenko wrote: > On Tue, Feb 9, 2016 at 10:11 PM, Rasmus Villemoes > wrote: > > The current code fails to call i2c_del_adapter on > > dev_prev->gmbus[0].adapter, and if the for loop above failed already > > at i==0, all hell breaks loose when we do the loop body for > > i = -1,-2,... > > > > Reviewed-by: Andy Shevchenko Applied to drm-misc, thanks. -Daniel > > > Signed-off-by: Rasmus Villemoes > > --- > > drivers/gpu/drm/gma500/intel_gmbus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c > > index 566d330aaeea..e7e22187c539 100644 > > --- a/drivers/gpu/drm/gma500/intel_gmbus.c > > +++ b/drivers/gpu/drm/gma500/intel_gmbus.c > > @@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev) > > return 0; > > > > err: > > - while (--i) { > > + while (i--) { > > struct intel_gmbus *bus = &dev_priv->gmbus[i]; > > i2c_del_adapter(&bus->adapter); > > } > > -- > > 2.1.4 > > > > > > -- > With Best Regards, > Andy Shevchenko > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus() Date: Wed, 10 Feb 2016 08:26:33 +0100 Message-ID: <20160210072633.GD11240@phenom.ffwll.local> References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30674720B8 for ; Tue, 9 Feb 2016 23:26:11 -0800 (PST) Received: by mail-wm0-f49.google.com with SMTP id 128so14461451wmz.1 for ; Tue, 09 Feb 2016 23:26:11 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andy Shevchenko Cc: Rasmus Villemoes , "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMTAsIDIwMTYgYXQgMDg6NDE6MTdBTSArMDIwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFR1ZSwgRmViIDksIDIwMTYgYXQgMTA6MTEgUE0sIFJhc211cyBWaWxsZW1v ZXMKPiA8bGludXhAcmFzbXVzdmlsbGVtb2VzLmRrPiB3cm90ZToKPiA+IFRoZSBjdXJyZW50IGNv ZGUgZmFpbHMgdG8gY2FsbCBpMmNfZGVsX2FkYXB0ZXIgb24KPiA+IGRldl9wcmV2LT5nbWJ1c1sw XS5hZGFwdGVyLCBhbmQgaWYgdGhlIGZvciBsb29wIGFib3ZlIGZhaWxlZCBhbHJlYWR5Cj4gPiBh dCBpPT0wLCBhbGwgaGVsbCBicmVha3MgbG9vc2Ugd2hlbiB3ZSBkbyB0aGUgbG9vcCBib2R5IGZv cgo+ID4gaSA9IC0xLC0yLC4uLgo+ID4KPiAKPiBSZXZpZXdlZC1ieTogQW5keSBTaGV2Y2hlbmtv IDxhbmR5LnNoZXZjaGVua29AZ21haWwuY29tPgoKQXBwbGllZCB0byBkcm0tbWlzYywgdGhhbmtz LgotRGFuaWVsCgo+IAo+ID4gU2lnbmVkLW9mZi1ieTogUmFzbXVzIFZpbGxlbW9lcyA8bGludXhA cmFzbXVzdmlsbGVtb2VzLmRrPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9p bnRlbF9nbWJ1cy5jIHwgMiArLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZ21hNTAw L2ludGVsX2dtYnVzLmMgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL2ludGVsX2dtYnVzLmMKPiA+ IGluZGV4IDU2NmQzMzBhYWVlYS4uZTdlMjIxODdjNTM5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2dtYTUwMC9pbnRlbF9nbWJ1cy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v Z21hNTAwL2ludGVsX2dtYnVzLmMKPiA+IEBAIC00MzYsNyArNDM2LDcgQEAgaW50IGdtYV9pbnRl bF9zZXR1cF9nbWJ1cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gICAgICAgICByZXR1cm4g MDsKPiA+Cj4gPiAgZXJyOgo+ID4gLSAgICAgICB3aGlsZSAoLS1pKSB7Cj4gPiArICAgICAgIHdo aWxlIChpLS0pIHsKPiA+ICAgICAgICAgICAgICAgICBzdHJ1Y3QgaW50ZWxfZ21idXMgKmJ1cyA9 ICZkZXZfcHJpdi0+Z21idXNbaV07Cj4gPiAgICAgICAgICAgICAgICAgaTJjX2RlbF9hZGFwdGVy KCZidXMtPmFkYXB0ZXIpOwo+ID4gICAgICAgICB9Cj4gPiAtLQo+ID4gMi4xLjQKPiA+Cj4gCj4g Cj4gCj4gLS0gCj4gV2l0aCBCZXN0IFJlZ2FyZHMsCj4gQW5keSBTaGV2Y2hlbmtvCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFp bGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==