From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/6] drm/i915: fix context/engine cleanup order Date: Wed, 10 Feb 2016 08:40:38 +0100 Message-ID: <20160210074038.GH11240@phenom.ffwll.local> References: <1453504211-7982-1-git-send-email-david.s.gordon@intel.com> <1453504211-7982-2-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id E252D6E64F for ; Tue, 9 Feb 2016 23:40:16 -0800 (PST) Received: by mail-wm0-f54.google.com with SMTP id c200so15329101wme.0 for ; Tue, 09 Feb 2016 23:40:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453504211-7982-2-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMjIsIDIwMTYgYXQgMTE6MTA6MDZQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gRnJvbTogTmljayBIb2F0aCA8bmljaG9sYXMuaG9hdGhAaW50ZWwuY29tPgo+IAo+IFN3 YXAgdGhlIG9yZGVyIG9mIGNvbnRleHQgJiBlbmdpbmUgY2xlYW51cCwgc28gdGhhdCBjb250ZXh0 cyBhcmUgY2xlYW5lZAo+IHVwIGZpcnN0LCBhbmQgKnRoZW4qIGVuZ2luZXMuIFRoaXMgaXMgYSBt b3JlIHNlbnNpYmxlIG9yZGVyIGFueXdheSwgYnV0Cj4gaW4gcGFydGljdWxhciBoYXMgYmVjb21l IG5lY2Vzc2FyeSBzaW5jZSB0aGUgJ2ludGVsX3JpbmdfaW5pdGlhbGl6ZWQoKQo+IG11c3QgYmUg c2ltcGxlIGFuZCBpbmxpbmUnIHBhdGNoLCB3aGljaCBub3cgdXNlcyByaW5nLT5kZXYgYXMgYW4K PiAnaW5pdGlhbGlzZWQnIGZsYWcsIHNvIGl0IGNhbiBub3cgYmUgTlVMTCBhZnRlciBlbmdpbmUg dGVhcmRvd24uIFRoaXMKPiBpbiB0dXJuIGNhbiBjYXVzZSBhIHByb2JsZW0gaW4gdGhlIGNvbnRl eHQgY29kZSwgd2hpY2ggKHVzZWQgdG8pIGNoZWNrCj4gdGhlIHJpbmctPmRldi0+c3RydWN0X211 dGV4IC0tIGNhdXNpbmcgYSBmYXVsdCBpZiByaW5nLT5kZXYgd2FzIE5VTEwuCj4gCj4gQWxzbyBy ZW5hbWUgdGhlIGNsZWFudXAgZnVuY3Rpb24gdG8gcmVmbGVjdCB3aGF0IGl0IGFjdHVhbGx5IGRv ZXMKPiAoY2xlYW51cCBlbmdpbmVzLCBub3QgYSByaW5nYnVmZmVyKSwgYW5kIGZpeCBhbiBhbm5v eWluZyB3aGl0ZXNwYWNlIGlzc3VlLgo+IAo+IHYyOiBBbHNvIG1ha2UgdGhlIGZpeCBpbiBpOTE1 X2xvYWRfbW9kZXNldF9pbml0LCBub3QganVzdCBpbgo+ICAgICBpOTE1X2RyaXZlcl91bmxvYWQg KENocmlzIFdpbHNvbikKPiB2MzogSGFkIGV4dHJhIHN0dWZmIGluIGl0Lgo+IHY0OiBSZXZlcnRl ZCBleHRyYSBzdHVmZiAoc28gd2UncmUgYmFjayB0byB2MikuCj4gICAgIFJlYmFzZWQgYW5kIHVw ZGF0ZWQgY29tbWVudGFyeSBhYm92ZSAoRGF2ZSBHb3Jkb24pLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhvYXRoQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBE YXZpZCBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gCj4gQ2M6IE1pa2EgS3VvcHBh bGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25A aW50ZWwuY29tPgoKUXVldWVkIGZvciAtbmV4dCwgdGhhbmtzIGZvciB0aGUgcGF0Y2guCi1EYW5p ZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgfCAgNCArKy0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jIHwgMjMgKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMyBmaWxl cyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZG1hLmMKPiBpbmRleCBkNzBkOTZmLi40NzI1ZThkIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RtYS5jCj4gQEAgLTQ1MSw4ICs0NTEsOCBAQCBzdGF0aWMgaW50IGk5MTVfbG9hZF9t b2Rlc2V0X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCj4gIGNsZWFudXBfZ2VtOgo+ ICAJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0JaTkxNV9nZW1fY2xlYW51cF9y aW5nYnVmZmVyKGRldik7Cj4gIAlpOTE1X2dlbV9jb250ZXh0X2ZpbmkoZGV2KTsKPiArCWk5MTVf Z2VtX2NsZWFudXBfZW5naW5lcyhkZXYpOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9t dXRleCk7Cj4gIGNsZWFudXBfaXJxOgo+ICAJaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoZGV2KTsKPiBA QCAtMTE5Niw4ICsxMTk2LDggQEAgaW50IGk5MTVfZHJpdmVyX3VubG9hZChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+ICAKPiAgCWludGVsX2d1Y191Y29kZV9maW5pKGRldik7Cj4gIAltdXRleF9s b2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gLQlpOTE1X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIo ZGV2KTsKPiAgCWk5MTVfZ2VtX2NvbnRleHRfZmluaShkZXYpOwo+ICsJaTkxNV9nZW1fY2xlYW51 cF9lbmdpbmVzKGRldik7Cj4gIAltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAg CWludGVsX2ZiY19jbGVhbnVwX2NmYihkZXZfcHJpdik7Cj4gIAlpOTE1X2dlbV9jbGVhbnVwX3N0 b2xlbihkZXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDIwNDY2MWYuLjAyMWU4 OGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMzAxMiw3ICszMDEyLDcgQEAg aW50IGk5MTVfZ2VtX2luaXRfcmluZ3Moc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIGludCBf X211c3RfY2hlY2sgaTkxNV9nZW1faW5pdF9odyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAg aW50IGk5MTVfZ2VtX2wzX3JlbWFwKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLCBp bnQgc2xpY2UpOwo+ICB2b2lkIGk5MTVfZ2VtX2luaXRfc3dpenpsaW5nKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpOwo+IC12b2lkIGk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KTsKPiArdm9pZCBpOTE1X2dlbV9jbGVhbnVwX2VuZ2luZXMoc3RydWN0IGRy bV9kZXZpY2UgKmRldik7Cj4gIGludCBfX211c3RfY2hlY2sgaTkxNV9ncHVfaWRsZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KTsKPiAgaW50IF9fbXVzdF9jaGVjayBpOTE1X2dlbV9zdXNwZW5kKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICB2b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRl eCAzNzFiYmIyLi43OTlhNTNhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTQ5 MTIsNyArNDkxMiw3IEBAIGludCBpOTE1X2dlbV9pbml0X3JpbmdzKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gIAkJcmVxID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhyaW5nLCBOVUxMKTsKPiAg CQlpZiAoSVNfRVJSKHJlcSkpIHsKPiAgCQkJcmV0ID0gUFRSX0VSUihyZXEpOwo+IC0JCQlpOTE1 X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIoZGV2KTsKPiArCQkJaTkxNV9nZW1fY2xlYW51cF9lbmdp bmVzKGRldik7Cj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KPiAgCj4gQEAgLTQ5MjUsNyArNDkyNSw3 IEBAIGludCBpOTE1X2dlbV9pbml0X3JpbmdzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAkJ aWYgKHJldCAmJiByZXQgIT0gLUVJTykgewo+ICAJCQlEUk1fRVJST1IoIlBQR1RUIGVuYWJsZSBy aW5nICMlZCBmYWlsZWQgJWRcbiIsIGksIHJldCk7Cj4gIAkJCWk5MTVfZ2VtX3JlcXVlc3RfY2Fu Y2VsKHJlcSk7Cj4gLQkJCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihkZXYpOwo+ICsJCQlp OTE1X2dlbV9jbGVhbnVwX2VuZ2luZXMoZGV2KTsKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+ICAK PiBAQCAtNDkzMyw3ICs0OTMzLDcgQEAgaW50IGk5MTVfZ2VtX2luaXRfcmluZ3Moc3RydWN0IGRy bV9kZXZpY2UgKmRldikKPiAgCQlpZiAocmV0ICYmIHJldCAhPSAtRUlPKSB7Cj4gIAkJCURSTV9F UlJPUigiQ29udGV4dCBlbmFibGUgcmluZyAjJWQgZmFpbGVkICVkXG4iLCBpLCByZXQpOwo+ICAJ CQlpOTE1X2dlbV9yZXF1ZXN0X2NhbmNlbChyZXEpOwo+IC0JCQlpOTE1X2dlbV9jbGVhbnVwX3Jp bmdidWZmZXIoZGV2KTsKPiArCQkJaTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKGRldik7Cj4gIAkJ CWdvdG8gb3V0Owo+ICAJCX0KPiAgCj4gQEAgLTUwMDgsNyArNTAwOCw3IEBAIGludCBpOTE1X2dl bV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgCj4gIHZvaWQKPiAtaTkxNV9n ZW1fY2xlYW51cF9yaW5nYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK2k5MTVfZ2Vt X2NsZWFudXBfZW5naW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqcmluZzsKPiBAQCAtNTAxNywxMyArNTAxNywxNCBAQCBpbnQgaTkx NV9nZW1faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJZm9yX2VhY2hfcmluZyhyaW5n LCBkZXZfcHJpdiwgaSkKPiAgCQlkZXZfcHJpdi0+Z3QuY2xlYW51cF9yaW5nKHJpbmcpOwo+ICAK PiAtICAgIGlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMpCj4gLSAgICAgICAgICAgIC8qCj4gLSAg ICAgICAgICAgICAqIE5laXRoZXIgdGhlIEJJT1MsIG91cnNlbHZlcyBvciBhbnkgb3RoZXIga2Vy bmVsCj4gLSAgICAgICAgICAgICAqIGV4cGVjdHMgdGhlIHN5c3RlbSB0byBiZSBpbiBleGVjbGlz dHMgbW9kZSBvbiBzdGFydHVwLAo+IC0gICAgICAgICAgICAgKiBzbyB3ZSBuZWVkIHRvIHJlc2V0 IHRoZSBHUFUgYmFjayB0byBsZWdhY3kgbW9kZS4KPiAtICAgICAgICAgICAgICovCj4gLSAgICAg ICAgICAgIGludGVsX2dwdV9yZXNldChkZXYpOwo+ICsJaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0 cykgewo+ICsJCS8qCj4gKwkJICogTmVpdGhlciB0aGUgQklPUywgb3Vyc2VsdmVzIG9yIGFueSBv dGhlciBrZXJuZWwKPiArCQkgKiBleHBlY3RzIHRoZSBzeXN0ZW0gdG8gYmUgaW4gZXhlY2xpc3Rz IG1vZGUgb24gc3RhcnR1cCwKPiArCQkgKiBzbyB3ZSBuZWVkIHRvIHJlc2V0IHRoZSBHUFUgYmFj ayB0byBsZWdhY3kgbW9kZS4KPiArCQkgKi8KPiArCQlpbnRlbF9ncHVfcmVzZXQoZGV2KTsKPiAr CX0KPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiAtLSAKPiAxLjkuMQo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==