All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "common/memsize.c: Simplify RAM size detection"
Date: Wed, 10 Feb 2016 10:36:54 +0100	[thread overview]
Message-ID: <20160210093654.41B4D3841F3@gemini.denx.de> (raw)
In-Reply-To: <56BAF2B1.3040507@redhat.com>

Dear Hans,

In message <56BAF2B1.3040507@redhat.com> you wrote:
> 
> It seems this code was as it was for a reason and that a revert
> of your simplification is probably the best solution.

Indeed. Over the past 15 years I have seen several attempts to
improve or simplify the mesize code.  Most did not make it into
mainline as they worked for the poster, but caused problems on some
other boards.

We had a similar "simplification" in 2012, see commit b8496cce and
revert in 3ab270d5, but all these attempts caused problems of some
kind, so the basic structure of the code is still exactly the same
as in the original version of 2004 (commit c83bf6a2).

Probably this is just Perfect Code (TM) which cannot improved further
:-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The word "fit", as I understand it, means "appropriate to a purpose",
and I would say the body of the Dean is supremely appropriate to  the
purpose of sitting around all day and eating big heavy meals.
                                 - Terry Pratchett, _Moving Pictures_

  parent reply	other threads:[~2016-02-10  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 21:38 [U-Boot] [PATCH] Revert "common/memsize.c: Simplify RAM size detection" Hans de Goede
2016-02-10  6:11 ` Eddy Petrișor
2016-02-10  8:20   ` Hans de Goede
2016-02-10  9:00     ` Eddy Petrișor
2016-02-10  9:36     ` Wolfgang Denk [this message]
2016-02-10 13:35 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160210093654.41B4D3841F3@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.